configure: add flag to disable OpenSSL tests #403

pull apoelstra wants to merge 1 commits into bitcoin-core:master from apoelstra:openssl-opt changing 2 files +26 −10

apoelstra commented at 11:02 AM on July 5, 2016: contributor

OpenSSL messes up valgrind.
apoelstra force-pushed on Jul 5, 2016

in configure.ac:None in 04ae82ac26 outdated

 349 | +        ;;
 350 | +      esac
 351 | +    fi
 352 | +  else
 353 | +    if test x"$enable_openssl_tests" = x"yes"; then
 354 | +      AC_MSG_ERROR([OpenSSL tests requested but not OpenSSL with EC support is not available])

sipa commented at 1:04 PM on July 5, 2016:

Not not?

apoelstra force-pushed on Jul 5, 2016

sipa commented at 3:01 PM on July 5, 2016: contributor

src/tests.c: In function ‘test_ecdsa_der_parse’:
src/tests.c:3503:32: warning: unused variable ‘max_scalar’ [-Wunused-variable]
     static const unsigned char max_scalar[32] = {

afk11 commented at 4:52 PM on July 5, 2016: contributor

See also: #382
configure: add flag to disable OpenSSL tests
OpenSSL messes up valgrind.
a9b2a5d850
apoelstra force-pushed on Jul 6, 2016
apoelstra commented at 8:26 AM on July 6, 2016: contributor

Thanks @afk11, fixed.
apoelstra cross-referenced this on Jul 6, 2016 from issue Suppress unused variable warning in automated test by Lewuathe
sipa commented at 10:07 AM on July 6, 2016: contributor

ACK
sipa merged this on Jul 6, 2016
sipa closed this on Jul 6, 2016
sipa referenced this in commit 65285a63ee on Jul 6, 2016
apoelstra deleted the branch on Jun 19, 2017

Contributors

apoelstra

sipa

afk11

Linked (view graph)

#382 Suppress unused variable warning in automated test