Don’t fail JNI dependency checks if we can build a JNI program #466

pull jgriffiths wants to merge 1 commits into bitcoin-core:master from jgriffiths:jni_fix changing 1 files +3 −0
  1. jgriffiths commented at 5:50 am on July 10, 2017: contributor

    Not all setups will result in JNI_INCLUDE_DIRS having a value, in particular Android builds from standalone toolchain directories have the JNI headers installed in the standard include directories.

    Instead of failing if the configure macro didn’t find a directory based on the installed Java runtime, only fail if we cannot build a JNI-including program.

  2. Don't fail JNI dependency checks if we can build a JNI program
    Not all setups will result in JNI_INCLUDE_DIRS having a value, in
    particular Android builds from standalone toolchain directories have
    the JNI headers installed in the standard include directories.
    
    Instead of failing if the configure macro didn't find a directory
    based on the installed Java runtime, only fail if we cannot build a
    JNI-including program.
    6af61c832d
  3. gmaxwell approved
  4. gmaxwell commented at 1:23 am on July 11, 2017: contributor
    Looks good to me. utACK
  5. sipa commented at 7:38 am on July 31, 2017: contributor
    @theuni Care to have a look?
  6. theuni commented at 3:18 pm on August 8, 2017: contributor
    This can re-enable jni if it’s been turned off because ecdh is disabled. I think the quick fix is just to move the enable_module_ecdh check down a bit.
  7. real-or-random cross-referenced this on Jan 7, 2020 from issue Remove Java Native Interface by jonasnick
  8. real-or-random commented at 11:12 am on February 10, 2020: contributor
    Closing this because we removed the JNI bindings in #682.
  9. real-or-random closed this on Feb 10, 2020


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-23 04:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me