tests: Make sure we’re not passing an uninitialized array to memcmp(…) #532

pull practicalswift wants to merge 1 commits into bitcoin-core:master from practicalswift:uninitialized changing 1 files +2 −2

practicalswift commented at 7:40 am on May 6, 2018: contributor

Make sure we’re not passing an uninitialized array to memcmp(...).
tests: Make sure we're not passing an uninitialized array to memcmp(...) 1eae9b1c69
gmaxwell commented at 4:38 am on February 21, 2019: contributor

I think this change would reduce the sensitivity of valgrind. By initializing it ourselves we’ll suppress errors where the underlying code, which should have initialized it at least up to the length we’re using failed to do so.
gmaxwell commented at 0:07 am on May 23, 2019: contributor

I still don’t see a reason to do this and there hasn’t been recent activity. I believe I understand the motivation, I think the disadvantage of masking errors that valgring/mem-santizer would find makes it not worth it. The valgrind component of the concern could be avoided by using valgrind macros to mark the array uninitilized but I’m aware of no comparable change for the sanitizers.
gmaxwell closed this on May 23, 2019
real-or-random cross-referenced this on May 23, 2019 from issue memcmp() may read unitiliazed memory in tests by real-or-random
practicalswift commented at 10:18 am on May 26, 2019: contributor

Fix in #627.
practicalswift cross-referenced this on May 26, 2019 from issue Guard memcmp in tests against mixed size inputs. by gmaxwell