Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config #561

1. 
   DesWurstes commented at 11:22 am on October 7, 2018: contributor

   Update: This is a trimmed pull request with strong rationale.

   • Adding --coverage shouldn’t reset LDFLAGS, this is definitely a typo
   • The basic configuration should undefine STATIC_PRECOMPUTATION, as generating it is not supported and it complicates #549
2. 
   roconnor-blockstream commented at 9:29 pm on February 15, 2019: contributor

   You probably also want to fix https://github.com/bitcoin-core/secp256k1/blob/b408c6a8b287003d1ade5709e6f7bc3c7f1d5be7/src/bench_internal.c#L189 as now the benchmark is invoking undefined behaviour rather than simply computing the wrong value.
3. Keep LDFLAGS if `--coverage` 310111e093
4. Undefine `STATIC_PRECOMPUTATION` if using the basic config dbed75d969
5. DesWurstes force-pushed on Feb 25, 2019
6. DesWurstes renamed this:
   Add restrict, remove extra whitespace, undef precomp, etc.
   Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config
   on Feb 25, 2019
7. 
   gmaxwell commented at 0:38 am on May 23, 2019: contributor

   ACK
8. gmaxwell merged this on May 23, 2019
9. gmaxwell closed this on May 23, 2019

   ---

10. gmaxwell referenced this in commit 912680ed86 on May 23, 2019
11. DesWurstes deleted the branch on Aug 21, 2019
12. sipa cross-referenced this on Jun 9, 2020 from issue Update libsecp256k1 subtree by sipa
13. fanquake referenced this in commit 8c97780db8 on Jun 13, 2020
14. sidhujag referenced this in commit 8a3a072968 on Jun 13, 2020
15. ComputerCraftr referenced this in commit b98f1c6e6c on Jun 16, 2020
16. UdjinM6 referenced this in commit 9d36ba6570 on Aug 10, 2021
17. 5tefan referenced this in commit 8ded2caa74 on Aug 12, 2021
18. gades referenced this in commit d855cc511d on May 8, 2022

Contributors
DesWurstes roconnor-blockstream gmaxwell