memcmp() may read unitiliazed memory in tests #623

issue real-or-random openend this issue on May 23, 2019
  1. real-or-random commented at 8:56 am on May 23, 2019: contributor

    If len_der != len_der_lax, then we may read uninitialized memory here: https://github.com/bitcoin-core/secp256k1/blob/912680ed8675bbf9c74c4c112ca3c41d27a295d7/src/tests.c#L4318

    This should probably be handled similar to https://github.com/bitcoin-core/secp256k1/blob/912680ed8675bbf9c74c4c112ca3c41d27a295d7/src/tests.c#L4302

    Same issues further below for the OpenSSL roundtrip.

    Loosely related to #532 but I agree that #532 is not a good idea.

  2. gmaxwell cross-referenced this on May 25, 2019 from issue Guard memcmp in tests against mixed size inputs. by gmaxwell
  3. gmaxwell closed this on May 29, 2019

  4. gmaxwell referenced this in commit ecc94abcc8 on May 29, 2019
  5. jonasnick referenced this in commit 103f62b092 on Sep 10, 2019


real-or-random


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-23 03:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me