naming: privkey vs seckey #670

1. 
   real-or-random commented at 1:38 am on October 9, 2019: contributor

   We have a bunch of secp256k1_ec_privkey_ functions but then we have secp256k1_ec_seckey_verify. I think we should create a privkey alias for this function.

   More generally, we sometimes write “private key” and sometimes “secret key”, and all the privkey functions expect a seckey argument. This should be made consistent too.

2. jonasnick cross-referenced this on Oct 9, 2019 from issue Make ec_ arithmetic more consistent and add documentation by jonasnick
3. 
   kroggen commented at 4:16 am on October 11, 2019: none

   What about using the privkey as default and let the seckey as the alias? So the function names are consistent.

   My vote goes to have the arguments named privkey too. Decreasing the amount of different names makes the code easier to understand.

4. 
   jonasnick commented at 11:52 am on October 11, 2019: contributor

   The thing is called seckey everywhere except the ec_privkey function names. So let’s keep that as a default.
5. 
   real-or-random commented at 12:26 pm on March 31, 2020: contributor

   Superseded by https://github.com/bitcoin-core/secp256k1/issues/671
6. real-or-random closed this on Mar 31, 2020

   ---

Contributors
real-or-random kroggen jonasnick