Remove OpenSSL benchmarks? #736

issue real-or-random openend this issue on April 9, 2020
  1. real-or-random commented at 11:23 am on April 9, 2020: contributor

    I think OpenSSL is useful for cross-testing (see #635) but I find the benchmark are annoying:

    • They take very long.
    • It’s currently not possible to disable them without disabling the OpenSSL tests.
    • Compilation of benchmark_verify is a special case in the build, see #735.

    I think the benchmarks were useful in the early days of this library to demonstrate that it outperforms OpenSSL but this not necessary anymore.

    Do people agree that we should remove them?

  2. elichai commented at 4:29 pm on April 9, 2020: contributor
    I’m fine with it. But I think I’ll look into implementing #716 this week to completely remote openssl
  3. elichai cross-referenced this on Apr 12, 2020 from issue Replace OpenSSL in cross-testing with micro-ecc(uECC) by elichai
  4. real-or-random cross-referenced this on Sep 28, 2021 from issue [RFC] Remove OpenSSL testing support by sipa
  5. sipa commented at 11:44 pm on September 28, 2021: contributor
    ACK (independent of whether we also get rid of the OpenSSL tests or not)
  6. real-or-random commented at 10:21 am on October 17, 2021: contributor
    resolved by #983
  7. real-or-random closed this on Oct 17, 2021


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-22 16:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me