Stop treating ECDH as experimental #809
pull jonasnick wants to merge 2 commits into bitcoin-core:master from jonasnick:ecdh-stable changing 3 files +4 −8-
jonasnick commented at 3:50 pm on September 8, 2020: contributorFixes #665
-
sipa commented at 2:44 am on September 9, 2020: contributorACK, I think it’s well tested and the API is sufficiently generic that I don’t expect it needing changes any time soon.
-
elichai commented at 11:25 am on September 9, 2020: contributorNice, ACK. so after this only ARM assembly is experimental here?
-
real-or-random commented at 2:33 pm on September 9, 2020: contributorACK 5a81a2ac249fc7a06517a1bc970c537f99c3a330
-
jonasnick force-pushed on Sep 12, 2020
-
jonasnick commented at 11:41 am on September 12, 2020: contributorrebased
-
jonasnick commented at 11:41 am on September 12, 2020: contributor
so after this only ARM assembly is experimental here?
and schnorrsig :)
-
in .travis.yml:40 in 2254932055 outdated
35@@ -36,8 +36,8 @@ env: 36 - CFLAGS=-O0 CTIMETEST= 37 - ECMULTGENPRECISION=2 38 - ECMULTGENPRECISION=8 39- - VALGRIND=yes ENDOMORPHISM=yes BIGNUM=no ASM=x86_64 EXPERIMENTAL=yes ECDH=yes RECOVERY=yes EXTRAFLAGS="--disable-openssl-tests" CPPFLAGS=-DVALGRIND BUILD= 40- - VALGRIND=yes BIGNUM=no ASM=x86_64 EXPERIMENTAL=yes ECDH=yes RECOVERY=yes EXTRAFLAGS="--disable-openssl-tests" CPPFLAGS=-DVALGRIND BUILD= 41+ - VALGRIND=yes ENDOMORPHISM=yes BIGNUM=no ASM=x86_64 ECDH=yes RECOVERY=yes EXTRAFLAGS="--disable-openssl-tests" CPPFLAGS=-DVALGRIND BUILD= 42+ - VALGRIND=yes BIGNUM=no ASM=x86_64 ECDH=yes RECOVERY=yes EXTRAFLAGS="--disable-openssl-tests" CPPFLAGS=-DVALGRIND BUILD=
elichai commented at 11:50 am on September 12, 2020:Can you leave the experimental but addSCHNORRSIG=yes
in both of these? (I can open a separate PR for that if you prefer)
jonasnick commented at 12:18 pm on September 12, 2020:good catch, donein .travis.yml:88 in 2254932055 outdated
84@@ -85,7 +85,7 @@ matrix: 85 - libc6-dbg:i386 86 # S390x build (big endian system) 87 - compiler: gcc 88- env: HOST=s390x-unknown-linux-gnu ECDH=yes RECOVERY=yes EXPERIMENTAL=yes CTIMETEST= 89+ env: HOST=s390x-unknown-linux-gnu ECDH=yes RECOVERY=yes CTIMETEST=
elichai commented at 11:50 am on September 12, 2020:Can you leave the experimental but addSCHNORRSIG=yes
in both of these? (I can open a separate PR for that if you prefer)
jonasnick commented at 12:18 pm on September 12, 2020:good catch, doneelichai commented at 4:53 pm on September 12, 2020: contributorACK 14392d64e60d4beca8e9d9c531d11b1e6a95e58ereal-or-random approvedreal-or-random commented at 9:12 am on September 13, 2020: contributorACK 14392d64e60d4beca8e9d9c531d11b1e6a95e58e code review, did not testsipa cross-referenced this on Sep 16, 2020 from issue Experimental features should be deprecated by rustyrussellsipa commented at 5:23 pm on October 20, 2020: contributorutACK 14392d64e60d4beca8e9d9c531d11b1e6a95e58e, but needs rebaseStop treating ECDH as experimental 353dff156ftravis: add schnorrsig to valgrind and big endian platform test e6e3d5da2fjonasnick force-pushed on Oct 20, 2020jonasnick commented at 5:54 pm on October 20, 2020: contributorrebasedreal-or-random approvedreal-or-random commented at 7:36 am on October 21, 2020: contributorACK e6e3d5da2f92f327019a62dc5f62f9335b2d0975elichai approvedelichai commented at 7:46 am on October 21, 2020: contributorACK e6e3d5dreal-or-random merged this on Oct 21, 2020real-or-random closed this on Oct 21, 2020
jasonbcox referenced this in commit e00ef916dd on Oct 22, 2020deadalnix referenced this in commit 2cebbc31b1 on Oct 23, 2020AdamISZ cross-referenced this on Jul 27, 2021 from issue secp256k1 version bump by kristapsk
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 05:15 UTC
This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 05:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me