Stop treating ECDH as experimental #809

1. 
   jonasnick commented at 3:50 pm on September 8, 2020: contributor

   Fixes #665
2. 
   sipa commented at 2:44 am on September 9, 2020: contributor

   ACK, I think it’s well tested and the API is sufficiently generic that I don’t expect it needing changes any time soon.
3. 
   elichai commented at 11:25 am on September 9, 2020: contributor

   Nice, ACK. so after this only ARM assembly is experimental here?
4. 
   real-or-random commented at 2:33 pm on September 9, 2020: contributor

   ACK 5a81a2ac249fc7a06517a1bc970c537f99c3a330
5. jonasnick force-pushed on Sep 12, 2020
6. 
   jonasnick commented at 11:41 am on September 12, 2020: contributor

   rebased
7. 
   jonasnick commented at 11:41 am on September 12, 2020: contributor

   so after this only ARM assembly is experimental here?

   and schnorrsig :)

8. in .travis.yml:40 in 2254932055 outdated

   35@@ -36,8 +36,8 @@ env:
   36     - CFLAGS=-O0 CTIMETEST=
   37     - ECMULTGENPRECISION=2
   38     - ECMULTGENPRECISION=8
   39-    - VALGRIND=yes ENDOMORPHISM=yes BIGNUM=no ASM=x86_64 EXPERIMENTAL=yes ECDH=yes  RECOVERY=yes EXTRAFLAGS="--disable-openssl-tests" CPPFLAGS=-DVALGRIND BUILD=
   40-    - VALGRIND=yes                  BIGNUM=no ASM=x86_64 EXPERIMENTAL=yes ECDH=yes  RECOVERY=yes EXTRAFLAGS="--disable-openssl-tests" CPPFLAGS=-DVALGRIND BUILD=
   41+    - VALGRIND=yes ENDOMORPHISM=yes BIGNUM=no ASM=x86_64 ECDH=yes  RECOVERY=yes EXTRAFLAGS="--disable-openssl-tests" CPPFLAGS=-DVALGRIND BUILD=
   42+    - VALGRIND=yes                  BIGNUM=no ASM=x86_64 ECDH=yes  RECOVERY=yes EXTRAFLAGS="--disable-openssl-tests" CPPFLAGS=-DVALGRIND BUILD=
   

   ---

   ---

   

   elichai commented at 11:50 am on September 12, 2020:

   Can you leave the experimental but add SCHNORRSIG=yes in both of these? (I can open a separate PR for that if you prefer)

   ---

   

   jonasnick commented at 12:18 pm on September 12, 2020:

   good catch, done
9. in .travis.yml:88 in 2254932055 outdated

   84@@ -85,7 +85,7 @@ matrix:
   85             - libc6-dbg:i386
   86     # S390x build (big endian system)
   87     - compiler: gcc
   88-      env: HOST=s390x-unknown-linux-gnu ECDH=yes RECOVERY=yes EXPERIMENTAL=yes CTIMETEST=
   89+      env: HOST=s390x-unknown-linux-gnu ECDH=yes RECOVERY=yes CTIMETEST=
   

   ---

   ---

   

   elichai commented at 11:50 am on September 12, 2020:

   Can you leave the experimental but add SCHNORRSIG=yes in both of these? (I can open a separate PR for that if you prefer)

   ---

   

   jonasnick commented at 12:18 pm on September 12, 2020:

   good catch, done
10. 
    elichai commented at 4:53 pm on September 12, 2020: contributor

    ACK 14392d64e60d4beca8e9d9c531d11b1e6a95e58e
11. real-or-random approved
12. 
    real-or-random commented at 9:12 am on September 13, 2020: contributor

    ACK 14392d64e60d4beca8e9d9c531d11b1e6a95e58e code review, did not test
13. sipa cross-referenced this on Sep 16, 2020 from issue Experimental features should be deprecated by rustyrussell
14. 
    sipa commented at 5:23 pm on October 20, 2020: contributor

    utACK 14392d64e60d4beca8e9d9c531d11b1e6a95e58e, but needs rebase
15. Stop treating ECDH as experimental 353dff156f
16. travis: add schnorrsig to valgrind and big endian platform test e6e3d5da2f
17. jonasnick force-pushed on Oct 20, 2020
18. 
    jonasnick commented at 5:54 pm on October 20, 2020: contributor

    rebased
19. real-or-random approved
20. 
    real-or-random commented at 7:36 am on October 21, 2020: contributor

    ACK e6e3d5da2f92f327019a62dc5f62f9335b2d0975
21. elichai approved
22. 
    elichai commented at 7:46 am on October 21, 2020: contributor

    ACK e6e3d5d
23. real-or-random merged this on Oct 21, 2020
24. real-or-random closed this on Oct 21, 2020

    ---

25. jasonbcox referenced this in commit e00ef916dd on Oct 22, 2020
26. deadalnix referenced this in commit 2cebbc31b1 on Oct 23, 2020
27. AdamISZ cross-referenced this on Jul 27, 2021 from issue secp256k1 version bump by kristapsk

Contributors
jonasnick sipa elichai real-or-random