Arm ASM builds are broken #931

issue gmaxwell openend this issue on May 2, 2021
  1. gmaxwell commented at 7:50 pm on May 2, 2021: contributor

    Gen_context tries to use ASM but doesn’t get linked against it:

    0gcc -O2 -fvisibility=hidden -std=c89 -pedantic -Wall -Wextra -Wcast-align -Wnested-externs -Wshadow -Wstrict-prototypes -Wundef -Wno-unused-function -Wno-long-long -Wno-overlength-strings -W -g  gen_context.o -o gen_context
    1gen_context.o: In function `secp256k1_fe_mul':
    2/home/gmaxwell/secp256k1/src/field_10x26_impl.h:1078: undefined reference to `secp256k1_fe_mul_inner'
    3gen_context.o: In function `secp256k1_fe_sqr':
    4/home/gmaxwell/secp256k1/src/field_10x26_impl.h:1091: undefined reference to `secp256k1_fe_sqr_inner'
    5/home/gmaxwell/secp256k1/src/field_10x26_impl.h:1091: undefined reference to `secp256k1_fe_sqr_inner'
    6/home/gmaxwell/secp256k1/src/field_10x26_impl.h:1091: undefined reference to `secp256k1_fe_sqr_inner'
    7/home/gmaxwell/secp256k1/src/field_10x26_impl.h:1091: undefined reference to `secp256k1_fe_sqr_inner'
    8...
    

    Reverting a3aa2628c7b675814157556d774872755c9f1aba fixes it.

  2. sipa commented at 8:17 pm on May 2, 2021: contributor
    Related: going to work on adding ARM32/ARM64 CI in #930 so that these things don’t silently break.
  3. real-or-random cross-referenced this on May 3, 2021 from issue Add ARM32/ARM64 CI by sipa
  4. real-or-random cross-referenced this on May 3, 2021 from issue Fix gen_context/ASM build on ARM by real-or-random
  5. real-or-random referenced this in commit 99f47c20ec on May 3, 2021
  6. sipa closed this on May 4, 2021

  7. AdamISZ cross-referenced this on Jul 27, 2021 from issue secp256k1 version bump by kristapsk
  8. dderjoel referenced this in commit bdba2ce45d on May 23, 2023


gmaxwell sipa


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-22 07:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me