These are two attempts to fix #931. @gmaxwell Can you test if either if the first commits solves the issue? (The third commit is just a minor cleanup thing that I discovered on the way).
If yes, I’d probably prefer the first commit, which is a real fix. But we could still apply the second commit if people think that’s a good idea.
This passes $(DEFS) (which should literally be "-DHAVE_CONFIG_H") to the
compiler and $(COMMON_LIB) (which is necessary when using external ASM
to the linker) when building gen_context.
Ok, CI answered my question: https://cirrus-ci.com/task/5313033309257728
The idea of the first commit is of course stupid and does not work when cross-compiling. We can’t simply link the $(COMMON_LIB) (e.g., built for ARM) into gen_context (e.g., build for x86).
The above CI failure is different but when I saw it, I still recognized my mistakes. So CI was a good teddy bear here.
I’ll open another PR with only the second commit and a rephrased comment.