BIP341: Fix definition of NUMS point #1406

pull real-or-random wants to merge 2 commits into bitcoin:master from real-or-random:patch-18 changing 1 files +1 −1
  1. real-or-random commented at 12:44 pm on January 12, 2023: contributor

    @sipa @jonasnick @ajtowns

    This removes the 02 prefix.

    I think the entire section is a little bit lax on “key” vs “point”: An earlier section defines “taproot output key” and “taproot internal key” to be (32byte) x-only keys, so it does not make sense to say “pick as internal key a point”, for instance. But I’m not fixing this in this PR.

  2. BIP341: Fix definition of NUMS point 996dd77b10
  3. apoelstra commented at 12:47 pm on January 12, 2023: contributor
    While we’re editing this line can we put the literal text “Nothing Up My Sleeve (NUMS)” into this line to make it easier to search for on the page?
  4. ajtowns commented at 12:49 pm on January 12, 2023: contributor
    ACK 996dd77b10f67059b2f0c958932cffa2e45edd53
  5. BIP341: Use the term "NUMS" 6e7e5a2523
  6. real-or-random commented at 12:52 pm on January 12, 2023: contributor

    While we’re editing this line can we put the literal text “Nothing Up My Sleeve (NUMS)” into this line to make it easier to search for on the page?

    done

  7. apoelstra approved
  8. apoelstra commented at 1:47 pm on January 12, 2023: contributor
    ACK 6e7e5a252376e0be46617434bf5d7f8bd2ce4ecb
  9. jonasnick commented at 2:10 pm on January 12, 2023: contributor
    ACK 6e7e5a252376e0be46617434bf5d7f8bd2ce4ecb
  10. ajtowns commented at 2:43 pm on January 12, 2023: contributor
    reACK 6e7e5a252376e0be46617434bf5d7f8bd2ce4ecb
  11. sipa commented at 3:11 pm on January 12, 2023: member
    ACK 6e7e5a252376e0be46617434bf5d7f8bd2ce4ecb
  12. sarahlivi1985 approved
  13. ajtowns cross-referenced this on Feb 21, 2023 from issue Mark Taproot BIPs as Final by uncomputable
  14. real-or-random commented at 10:40 pm on June 6, 2023: contributor
    @kallewoof @luke-jr Is there anything that needs to be done before this can get merged?
  15. luke-jr merged this on Jun 29, 2023
  16. luke-jr closed this on Jun 29, 2023

  17. luke-jr commented at 5:49 pm on June 29, 2023: member
    No, sorry for the delay

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 17:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me