bip360: fix stale links, version header and a size example label #2221

pull jeanpablojp wants to merge 1 commits into bitcoin:master from jeanpablojp:bip360-fix-links changing 1 files +4 −4

jeanpablojp commented at 8:44 PM on July 27, 2026: contributor
Small doc fixes in bip-0360.mediawiki, noticed while implementing against the published vectors:
- The Test Vectors section linked P2MR_construction.json; the file on disk is lowercase p2mr_construction.json, so the link 404s.
- The same section still linked the rust implementation under bip-0360/ref-impl/rust, which #2202 moved out of the repository. Kept the python link and adjusted the sentence around it.
- The header said Version: 0.12.0 while the changelog's latest entry is 0.12.1.
- The 135-byte depth-1 witness example labeled the merkle path "(empty)" while counting 32 bytes for it. A depth-1 path has one 32-byte node.
Two things I left unchanged because they affect consumers' parsers: the schema mixes given.scriptTree (most vectors) with given.script_tree (the missing-tree error vectors), and a missing tree is encoded both as null and as an empty string. Happy to normalize those too if there is a preferred spelling.

bip360: fix stale links, version header and a size example label

- The Test Vectors section linked P2MR_construction.json; the file on
  disk is lowercase p2mr_construction.json, so the link 404s.
- The same section still linked the rust implementation under
  bip-0360/ref-impl/rust, which #2202 moved out of the repository.
- The header said Version: 0.12.0 while the changelog's latest entry
  is 0.12.1.
- The 135-byte depth-1 witness example labeled the merkle path
  "(empty)" while counting 32 bytes for it (a depth-1 path has one
  32-byte node).

19f5a224ee

jonatack added the label Bug fix on Jul 27, 2026
jonatack added the label Link fix on Jul 27, 2026
jonatack added the label Fixups on Jul 27, 2026
in bip-0360.mediawiki:284 in 19f5a224ee
```
 280 | @@ -281,7 +281,7 @@ P2MR witness for a depth-1 tree (135 bytes):
 281 |  [count] (1 byte), # Number of elements in the witness
 282 |  [size] signature (1 + 64 bytes = 65 bytes),
 283 |  leaf script = [size] [OP_PUSHBYTES_32, 32-byte public key, OP_CHECKSIG] (1 + 1 + 32 + 1 bytes = 35 bytes),
 284 | -control block = [size] [control byte] [merkle path (empty)] (1 + 1 + 32 bytes = 34 bytes)
 285 | +control block = [size] [control byte] [merkle path] (1 + 1 + 32 bytes = 34 bytes)
```
jonatack commented at 9:35 PM on July 27, 2026:

@cryptoquick @EthanHeilman can I get your feedback on this? It looks correct to me.

(Also on this, from the PR description):

"Two things I left unchanged because they affect consumers' parsers: the schema mixes given.scriptTree (most vectors) with given.script_tree (the missing-tree error vectors), and a missing tree is encoded both as null and as an empty string. Happy to normalize those too if there is a preferred spelling."

cryptoquick commented at 8:42 PM on August 1, 2026:

Yes, this is correct, and now is the time to fix what's not ideal now, because technical debt and such like this have a tendency to compound, especially after activation.

Keep up the good work, guys.
jonatack commented at 9:36 PM on July 27, 2026: member

ACK, good fixups (thanks!)
jonatack removed the label Bug fix on Jul 27, 2026
cryptoquick commented at 8:43 PM on August 1, 2026: contributor

ACK
jonatack merged this on Aug 2, 2026
jonatack closed this on Aug 2, 2026

Contributors

Labels

Linked (view graph)

#2202 bip360: add python example impl, drop Rust/JS ones; test vector fixes