#9818 was opened before we had logging in the test framework and added a print() call to importmulti.py. log.info() is preferred now that we have logging in the test framework.
[trivial] Use log.info() instead of print() in remaining functional test cases. #10024
pull jnewbery wants to merge 2 commits into bitcoin:master from jnewbery:uselogginginimportmulti changing 4 files +10 −7-
jnewbery commented at 10:05 PM on March 17, 2017: member
-
Use log.info() instead of print() in importmulti.py 1f7065367c
-
TheBlueMatt commented at 10:18 PM on March 17, 2017: member
utACK 1f7065367c6e901f1f047f4bc0ce63633fd7602b Looks like there are additional prints in nulldummy.py and proxy_test.
-
fix logging in nulldummy and proxy_test e722777a49
-
jnewbery commented at 10:39 PM on March 17, 2017: member
Thanks @TheBlueMatt . I originally didn't add logging to proxy_test.py because it was printing in
__int__(), which is before logging has been set up. Looking a bit closer, it's very easy to move the logic from__init__()intosetup_nodes(), which I think is where it belongs.nulldummy.py was just an oversight.
I'll squash these commits once they've been reviewed.
- jnewbery renamed this:
[trivial] Use log.info() instead of print() in importmulti.py
[trivial] Use log.info() instead of print() in remaining functional test cases.
on Mar 17, 2017 - fanquake added the label Tests on Mar 18, 2017
-
laanwj commented at 10:14 AM on March 18, 2017: member
-
MarcoFalke commented at 9:12 AM on March 19, 2017: member
utACK e722777
- MarcoFalke merged this on Mar 19, 2017
- MarcoFalke closed this on Mar 19, 2017
- MarcoFalke referenced this in commit 9225de2cf6 on Mar 19, 2017
- PastaPastaPasta referenced this in commit 35c9af9a68 on Mar 10, 2019
- PastaPastaPasta referenced this in commit 70a060e4fb on Mar 11, 2019
- PastaPastaPasta referenced this in commit 7701669b43 on Mar 11, 2019
- PastaPastaPasta referenced this in commit 194c662b93 on Mar 12, 2019
- PastaPastaPasta referenced this in commit 69dfbd807f on Mar 13, 2019
- UdjinM6 referenced this in commit ce264bb34e on Mar 13, 2019
- PastaPastaPasta referenced this in commit 43ed571d1e on Mar 13, 2019
- PastaPastaPasta referenced this in commit be49ef4f04 on Mar 14, 2019
- PastaPastaPasta referenced this in commit 549b249219 on Mar 14, 2019
- PastaPastaPasta referenced this in commit ce7ad81a00 on Mar 15, 2019
- PastaPastaPasta referenced this in commit 3555a40a42 on Mar 16, 2019
- PastaPastaPasta referenced this in commit 70f22519bb on Apr 3, 2019
- PastaPastaPasta referenced this in commit f230cc11d9 on Apr 3, 2019
- PastaPastaPasta referenced this in commit 3b4f910b7c on Apr 5, 2019
- PastaPastaPasta referenced this in commit 22563f3698 on May 6, 2019
- barrystyle referenced this in commit 8ab409c425 on Jan 22, 2020
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels