Save watch only key timestamps when reimporting keys #9818

pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/multirewatch changing 2 files +24 −5

ryanofsky commented at 4:10 PM on February 21, 2017: member

Previously if an existing watch only key was reimported with a new timestamp, the new timestamp would not be saved in the key metadata, and would not be used to update the wallet nTimeFirstKey value (which could cause rescanning to start at the wrong point and miss transactions).

Issue was pointed out by @jonasschnelli in #9108 (comment)
laanwj added the label Wallet on Feb 21, 2017
TheBlueMatt commented at 4:39 PM on February 22, 2017: member

utACK a496e1677560c95185b666a5683f01e2641dd7c4 didnt review test.

Save watch only key timestamps when reimporting keys

Previously if an existing watch only key was reimported with a new timestamp,
the new timestamp would not be saved in the key metadata, and would not be used
to update the wallet nTimeFirstKey value (which could cause rescanning to start
at the wrong point and miss transactions).

Issue was pointed out by Jonas Schnelli <dev@jonasschnelli.ch> in
https://github.com/bitcoin/bitcoin/pull/9108#issuecomment-279715550

7759aa23d1

ryanofsky force-pushed on Mar 3, 2017
ryanofsky commented at 7:19 PM on March 3, 2017: member

Rebased a496e1677560c95185b666a5683f01e2641dd7c4 -> 7759aa23d1db88230b67703f8e3235afa9225c08 (pr/multirewatch.0 -> pr/multirewatch.1) because of conflicts with pwalletMain renames in #9775.
jonasschnelli commented at 3:01 PM on March 17, 2017: contributor

Tested ACK 7759aa23d1db88230b67703f8e3235afa9225c08
laanwj merged this on Mar 17, 2017
laanwj closed this on Mar 17, 2017
laanwj referenced this in commit 3d857f307b on Mar 17, 2017
jnewbery commented at 10:02 PM on March 17, 2017: member

post-merge tested ACK https://github.com/bitcoin/bitcoin/commit/7759aa23d1db88230b67703f8e3235afa9225c08. Only nit is that this should use self.log.info() instead of print() now that we have logging in the test framework (I realise logging wasn't merged when you opened this PR). I'll open a [trivial] PR to change that.

I should also really write some developer notes for writing functional tests.
PastaPastaPasta referenced this in commit c298451420 on Mar 10, 2019
PastaPastaPasta referenced this in commit 83e1799f1b on Mar 11, 2019
PastaPastaPasta referenced this in commit 1c6e1e7750 on Mar 11, 2019
PastaPastaPasta referenced this in commit 8e040734a3 on Mar 12, 2019
PastaPastaPasta referenced this in commit 2683679eeb on Mar 13, 2019
UdjinM6 referenced this in commit 3c941ed114 on Mar 13, 2019
PastaPastaPasta referenced this in commit 99d833701b on Mar 13, 2019
PastaPastaPasta referenced this in commit b01ef53e3c on Mar 14, 2019
PastaPastaPasta referenced this in commit 0b65d740e6 on Mar 14, 2019
PastaPastaPasta referenced this in commit bdb1cda880 on Mar 15, 2019
PastaPastaPasta referenced this in commit d78d770812 on Mar 16, 2019
PastaPastaPasta referenced this in commit cf382a0a87 on Apr 3, 2019
PastaPastaPasta referenced this in commit e9c576b23c on Apr 3, 2019
PastaPastaPasta referenced this in commit f3eaee4ceb on Apr 5, 2019
PastaPastaPasta referenced this in commit 6376da03fa on May 6, 2019
barrystyle referenced this in commit 761a8e093c on Jan 22, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#9108 Use importmulti timestamp when importing watch only keys (on top of #9682)#10024 [trivial] Use log.info() instead of print() in remaining functional test cases.