No description provided.
[tests] Remove unused variables and imports #10047
pull practicalswift wants to merge 2 commits into bitcoin:master from practicalswift:remove-unused-python-imports changing 11 files +6 −16-
practicalswift commented at 12:37 AM on March 22, 2017: contributor
- practicalswift renamed this:
[tests] Remove unused and duplicate imports
[tests] Remove unused and duplicate Python imports
on Mar 22, 2017 - fanquake added the label Tests on Mar 22, 2017
-
fanquake commented at 12:41 AM on March 22, 2017: member
I'm surprised there are so many to remove again, given this was only done two months ago (#9508).
-
jonasschnelli commented at 7:39 AM on March 22, 2017: contributor
utACK d3073c232a7a0ad182cf4d9eb1495c79795669e9
-
jonasschnelli commented at 7:40 AM on March 22, 2017: contributor
Maybe add commit from #10049 here? Trivial PRs tend to distract and therefore combining should be okay and desirable.
-
jnewbery commented at 4:45 PM on March 22, 2017: member
Tested ACK d3073c232a7a0ad182cf4d9eb1495c79795669e9 @fanquake - there's been a lot of churn in the test directory recently, which is how some of these have crept in.
Longer term, I expect we'll continue to see unused imports until we have a sensible import scheme for the functional tests such as #9876 (comment). Static analysis tools can't work out wildcard imports and linters like flake8 throw up many errors when wildcards are used, so I expect no-one is using linters before committing.
-
[tests] Remove unused and duplicate imports 72163d4585
-
[tests] Remove unused variables 389745901a
- practicalswift force-pushed on Mar 22, 2017
- practicalswift renamed this:
[tests] Remove unused and duplicate Python imports
[tests] Remove unused variables and imports
on Mar 22, 2017 -
practicalswift commented at 4:53 PM on March 22, 2017: contributor
@jonasschnelli Good point! Added the commit from #10049 into this PR :-)
-
-
paveljanik commented at 7:18 AM on March 23, 2017: contributor
utACK 3897459
-
MarcoFalke commented at 10:37 AM on March 23, 2017: member
utACK 3897459
- MarcoFalke merged this on Mar 23, 2017
- MarcoFalke closed this on Mar 23, 2017
- MarcoFalke referenced this in commit dfef6b6af0 on Mar 23, 2017
- PastaPastaPasta referenced this in commit cc6a14213e on Mar 14, 2019
- jasonbcox referenced this in commit ef4c9456bb on May 15, 2019
- PastaPastaPasta referenced this in commit 8247eff34d on May 20, 2019
- markblundeberg referenced this in commit fb65183238 on May 20, 2019
- PastaPastaPasta referenced this in commit 9f07f489de on May 21, 2019
- PastaPastaPasta referenced this in commit 35e18d7b9a on May 21, 2019
- jonspock referenced this in commit cf239e8073 on Jun 13, 2019
- barrystyle referenced this in commit 789adc42eb on Jan 22, 2020
- practicalswift deleted the branch on Apr 10, 2021
- DrahtBot locked this on Aug 16, 2022
Labels