[test] Run extended tests once daily in Travis #10052

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:traviscronjobs changing 1 files +2 −1
  1. jnewbery commented at 3:11 PM on March 22, 2017: member

    Travis has beta support for a new feature called cron jobs. We should hook into this to run our extended functional test suite once per day.

    This requires two changes: merging the change to .travis.yml in this PR, and then enabling daily builds of the master branch through Travis settings.

    For an example of a cron build see https://travis-ci.org/jnewbery/bitcoin/builds/213827649. This currently fails because:

    • rpcbind_tests.py requires ipv6, which Travis currently doesn't support. I have a workaround for that on the way.
    • pruning.py times out. I've now updated the .travis.yml file to exclude running pruning.

    The granularity for cron jobs is very coarse - currently Travis only allows jobs to be run daily, weekly or monthly. There have been lots of requests for more flexible cron schedules in this thread so Travis may add this as an enhancement at some point.

  2. Run extended tests once daily 88e3aa0bcb
  3. jnewbery renamed this:
    Run extended tests once daily in Travis
    [test] Run extended tests once daily in Travis
    on Mar 22, 2017
  4. MarcoFalke commented at 6:52 PM on March 22, 2017: member

    Do you know if emails will be sent out to the maintainers on failing builds? I think we'd want to avoid that, as the extended tests on travis could end up being rather flaky.

    utACK 88e3aa0 otherwise.

    On Wed, Mar 22, 2017 at 4:11 PM, John Newbery notifications@github.com wrote:

    Travis has beta support for a new feature called cron jobs. We should hook into this to run our extended functional test suite once per day.

    This requires two changes: merging the change to .travis.yml in this PR, and then enabling daily builds of the master branch through Travis settings.

    For an example of a cron build see https://travis-ci.org/jnewbery/bitcoin/builds/213827649. This currently fails because:

    rpcbind_tests.py requires ipv6, which Travis currently doesn't support. I have a workaround for that on the way. pruning.py times out. I've now updated the .travis.yml file to exclude running pruning.

    The granularity for cron jobs is very coarse - currently Travis only allows jobs to be run daily, weekly or monthly. There have been lots of requests for more flexible cron schedules in this thread so Travis may add this as an enhancement at some point.


    You can view, comment on, or merge this pull request online at:

    #10052

    Commit Summary

    Run extended tests once daily

    File Changes

    M .travis.yml (3)

    Patch Links:

    #10052.patch #10052.diff

    — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

  5. jnewbery commented at 7:12 PM on March 22, 2017: member

    I think email notifications for cron jobs are the same as for regular branch builds.

    In any case, I'm not sure whether that's a bad thing. If the test is really broken, then it's better to know immediately that something's broken it, rather than whenever someone happens to run the extended tests. And if you're worried about the extended tests being unreliable, then we should make them more robust.

  6. MarcoFalke commented at 7:23 PM on March 22, 2017: member

    It is fine when the failure can be reproduced locally, though there have been cases where travis just fails out of the blue and as soon as you try to debug, it will behave as if nothing was wrong.

    As you can see in the log of the cron job in your fork, bip9-softforks sometimes fails: https://travis-ci.org/jnewbery/bitcoin/jobs/213827655

    I tried to reproduce this failure locally but it always passes for me...

    On Wed, Mar 22, 2017 at 8:13 PM, John Newbery notifications@github.com wrote:

    I think email notifications for cron jobs are the same as for regular branch builds.

    In any case, I'm not sure whether that's a bad thing. If the test is really broken, then it's better to know immediately that something's broken it, rather than whenever someone happens to run the extended tests. And if you're worried about the extended tests being unreliable, then we should make them more robust.

    — You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/10052#issuecomment-288508365, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGmv7HhG2DsFdvilONDhkuGpOhlEREqks5roXLIgaJpZM4MlWf4 .

  7. jnewbery commented at 7:44 PM on March 22, 2017: member

    Yes - that could get annoying. I plan to improve travis logging by having it upload detailed logs from failed test cases to an S3 bucket. In the long run we should definitely try to make sure travis runs of extended test cases are reliable, but for now you could manually exclude those test cases which you think are unreliable?

  8. fanquake added the label Tests on Mar 22, 2017
  9. jtimon commented at 7:08 PM on March 23, 2017: contributor

    Concept ACK

  10. MarcoFalke merged this on Mar 24, 2017
  11. MarcoFalke closed this on Mar 24, 2017

  12. MarcoFalke referenced this in commit a0b1e57b20 on Mar 24, 2017
  13. jnewbery commented at 1:34 PM on March 24, 2017: member

    Great! Now I need to fix bip9-softforks.py :)

  14. jnewbery commented at 9:08 PM on March 24, 2017: member

    I believe #10072 should help with bip9-softforks.

  15. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me