[qa] Fundraw: Use named args to limit scope of names #10078

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1703-qaNamedShadow changing 1 files +82 −82

MarcoFalke commented at 3:46 PM on March 25, 2017: member
Thanks to @laanwj, it is now possible to use named args to limit the scope of names in the fundrawtransaction script. In a first step this is done for the variables inputs, outputs, which have previously been overwritten for each test.

Hint to get a more pleasing diff:
```
git diff HEAD~ --word-diff-regex=[^[:space:]]
```
MarcoFalke added the label Tests on Mar 25, 2017
[qa] Fundraw: Use named args to limit scope of names fa03300240
MarcoFalke force-pushed on Mar 26, 2017

laanwj commented at 6:54 AM on March 27, 2017: member

Concept ACK

Error from travis:

2017-03-26 11:26:24.763000 TestFramework (INFO): Initializing test directory /tmp/testpiujey_0/218
2017-03-26 11:26:27.857000 TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 150, in main
    self.run_test()
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/fundrawtransaction.py", line 75, in run_test
    outputs={self.nodes[0].getnewaddress(): 1.0})
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/coverage.py", line 46, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/authproxy.py", line 153, in __call__
    raise JSONRPCException(response['error'])
test_framework.authproxy.JSONRPCException: Unknown named parameter inputs (-8)

jnewbery commented at 1:48 PM on April 5, 2017: member

I've tested this after rebasing on top of master (in order to get the fix for #10084) and it passes.

Rebase conflicted with #10083. Feel free to take https://github.com/jnewbery/bitcoin/commit/c268d193a0d68f9009e5ee24a2e1eb2aa0f70b83 to avoid having to do the merge.
MarcoFalke commented at 9:16 AM on April 16, 2017: member

outputs is still used in 5 instances on the larger scope. I don't see the benefit in this pull. Closing.
MarcoFalke closed this on Apr 16, 2017
MarcoFalke deleted the branch on Apr 16, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#10083 [QA] Renaming rawTx into rawtx