rpc: Rename first named arg of createrawtransaction #10084

1. 
   MarcoFalke commented at 10:10 AM on March 26, 2017: member

   Fixes #10079.

2. rpc: Rename first named arg of createrawtransaction fa55853219
3. MarcoFalke added the label RPC/REST/ZMQ on Mar 26, 2017
4. MarcoFalke added the label Needs backport on Mar 26, 2017
5. MarcoFalke added the label Needs release notes on Mar 26, 2017
6. MarcoFalke added this to the milestone 0.14.1 on Mar 26, 2017
7. dcousens approved
8. 
   dcousens commented at 11:22 AM on March 26, 2017: contributor

   ACK

9. 
   NicolasDorier commented at 1:40 PM on March 26, 2017: contributor

   utACK

10. 
    laanwj commented at 7:36 AM on March 27, 2017: member

    utACK https://github.com/bitcoin/bitcoin/pull/10084/commits/fa558532192ca0bb519f811ee14df6037413b89f. Makes sense. As this is an API change, this needs mention in the release notes.

11. 
    jonasschnelli commented at 7:39 AM on March 27, 2017: contributor

    ACK fa558532192ca0bb519f811ee14df6037413b89f

12. MarcoFalke referenced this in commit 05997c7120 on Mar 27, 2017
13. MarcoFalke referenced this in commit e823a10ba3 on Mar 27, 2017
14. MarcoFalke referenced this in commit 142fbb2fec on Mar 27, 2017
15. MarcoFalke removed the label Needs backport on Mar 27, 2017
16. MarcoFalke removed the label Needs release notes on Mar 27, 2017
17. 
    TheBlueMatt commented at 10:42 PM on March 27, 2017: contributor

    Hmm, I suppose it's unlikely anyone is even using named args in 0.14 yet, so probably fine, but as folks start using this we should prefer to update docs over code.

    utACK fa558532192ca0bb519f811ee14df6037413b89f

18. 
    laanwj commented at 7:36 AM on March 29, 2017: member

    Hmm, I suppose it's unlikely anyone is even using named args in 0.14 yet, so probably fine, but as folks start using this we should prefer to update docs over code.

    In general you are right, but in this specific case 'inputs' is a much better name for the argument. I think this slipped by in review of #8811.

19. laanwj merged this on Mar 29, 2017
20. laanwj closed this on Mar 29, 2017

    ---

21. laanwj referenced this in commit 9692be4a9a on Mar 29, 2017
22. MarcoFalke deleted the branch on Mar 29, 2017
23. jnewbery cross-referenced this on Apr 5, 2017 from issue [qa] Fundraw: Use named args to limit scope of names by MarcoFalke
24. MarcoFalke cross-referenced this on Apr 13, 2017 from issue [net] Allow disconnectnode RPC to be called with node id by jnewbery
25. codablock referenced this in commit 8aa00505ff on Jan 26, 2018
26. andvgal referenced this in commit 125e691287 on Jan 6, 2019
27. CryptoCentric referenced this in commit 634643a468 on Feb 27, 2019
28. random-zebra cross-referenced this on May 13, 2021 from issue [RPC] Support for JSON-RPC named arguments by random-zebra
29. furszy referenced this in commit 29650e00cf on Jun 2, 2021
30. bitcoin locked this on Sep 8, 2021

Contributors

MarcoFalkedcousensNicolasDorierlaanwjjonasschnelliTheBlueMatt

Milestone
0.14.1