Make qt wallet test compatible with qt4 #10098

1. 
   ryanofsky commented at 6:47 pm on March 27, 2017: member

   Unlike Qt5, the Qt4 signals implementation doesn’t allow a signal to be directly connected to a c++ lambda expression. Work around this by defining a Callback QObject with a virtual method that can forward calls to a closure.

   The Qt4 error was reported by @pstratem in #10039 (comment)

2. Make qt wallet test compatible with qt4

   Unlike Qt5, the Qt4 signals implementation doesn't allow a signal to be
   directly connected to a c++ lambda expression. Work around this by defining a
   Callback QObject with a virtual method that can forward calls to a closure.
   
   The Qt4 error was reported by Patrick Strateman <patrick.strateman@gmail.com>
   in https://github.com/bitcoin/bitcoin/pull/10039#issuecomment-289248763

   e9a64615c8
3. 
   pstratem commented at 9:30 pm on March 27, 2017: contributor

   tested but i have no idea about qt so uh tested-almost-ack ?
4. fanquake added the label Tests on Mar 28, 2017
5. fanquake added the label Wallet on Mar 28, 2017
6. jonasschnelli added the label GUI on Mar 28, 2017
7. 
   jonasschnelli commented at 6:25 am on March 28, 2017: contributor

   This is a really nice approach how to keep lambda-ish syntax for Qt4 signals. utACK e9a64615c8e18692a775765787f404266767260b. Will test soon.
8. 
   laanwj commented at 8:15 am on March 29, 2017: member

   tested but i have no idea about qt so uh tested-almost-ack ?

   You don’t need to have an idea about qt to confirm whether the test compiles and passes on qt4 after this (which I guess you did?).

9. 
   jonasschnelli commented at 7:35 am on March 30, 2017: contributor

   Tested ACK e9a64615c8e18692a775765787f404266767260b. Could successfully compile this on my Ubuntu 14.04.5 QT4 VM.
10. in src/qt/callback.h:1 in e9a64615c8

    0@@ -0,0 +1,30 @@
    1+#ifndef BITCOIN_QT_CALLBACK_H
    

    ---

    ---

    

    paveljanik commented at 7:39 am on March 30, 2017:

    Copyright header missing.
11. 
    paveljanik commented at 8:00 am on March 30, 2017: contributor

    utACK https://github.com/bitcoin/bitcoin/commit/e9a64615c8e18692a775765787f404266767260b

    Can’t test with Qt4 though.

12. gmaxwell approved
13. 
    gmaxwell commented at 1:12 am on April 2, 2017: contributor

    tested ACK. (without this, master does not compile on my debian host)
14. laanwj merged this on Apr 2, 2017
15. laanwj closed this on Apr 2, 2017

    ---

16. laanwj referenced this in commit 2b477e6aa1 on Apr 2, 2017
17. laanwj referenced this in commit 96c409c919 on Oct 20, 2018
18. PastaPastaPasta referenced this in commit 5153441db3 on May 20, 2019
19. PastaPastaPasta referenced this in commit 5bf69e39b5 on May 20, 2019
20. PastaPastaPasta referenced this in commit dba492d274 on May 20, 2019
21. PastaPastaPasta referenced this in commit 818858248c on May 20, 2019
22. PastaPastaPasta referenced this in commit 5d34838b30 on May 20, 2019
23. PastaPastaPasta referenced this in commit d0033f2445 on May 21, 2019
24. PastaPastaPasta referenced this in commit 4121daba28 on May 21, 2019
25. PastaPastaPasta referenced this in commit b7d2e2e97d on May 21, 2019
26. barrystyle referenced this in commit b4565f13dd on Jan 22, 2020
27. DrahtBot locked this on Sep 8, 2021

Contributors
ryanofsky pstratem jonasschnelli laanwj paveljanik gmaxwell

Labels
GUI Wallet Tests