Fix test_bitcoin-qt when DISPLAY is unset #10113

pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/nodisp changing 2 files +28 −2

ryanofsky commented at 9:16 PM on March 28, 2017: member

Issue reported by @TheBlueMatt in #10110

Fix test_bitcoin-qt when DISPLAY is unset

Issue reported by Matt Corallo <git@bluematt.me> in
https://github.com/bitcoin/bitcoin/issues/10110

Fixes #10110

ebbce1268c

in src/qt/test/test_main.cpp:47 in ebbce1268c
```
  42 | @@ -41,6 +43,15 @@ Q_IMPORT_PLUGIN(QCocoaIntegrationPlugin);
  43 |  #endif
  44 |  #endif
  45 |  
  46 | +static bool UsesXcb() {
  47 | +    for (QObject* plugin: QPluginLoader::staticInstances()) {
```
theuni commented at 12:32 AM on March 29, 2017:

How does this react if xcb is available but not default? For ex, if egl or wayland would otherwise be used?

ryanofsky commented at 7:02 PM on March 29, 2017:

How does this react if xcb is available but not default? For ex, if egl or wayland would otherwise be used?

This is a good point, I suspect the check is broken in this case.
fanquake added the label Tests on Mar 29, 2017
laanwj commented at 7:30 AM on March 29, 2017: member

I think the make check tests should never try to use the DISPLAY (or the computer's GUI otherwise, e.g. through egl/wayland/win32/quartz/...). There's a place for tests that require rendering (usually combined with a "monkey" to mimic user interaction) but these should IMO be separate when we have them.
ryanofsky commented at 7:12 PM on March 29, 2017: member

I think the make check tests should never try to use the DISPLAY (or the computer's GUI otherwise, e.g. through egl/wayland/win32/quartz/...). There's a place for tests that require rendering (usually combined with a "monkey" to mimic user interaction) but these should IMO be separate when we have them.

The test doesn't actually require any rendering, it's just failing to initialize QApplication (which must be calling some libxcb functions) and crashing on startup.

I'm closing this in favor of an alternative fix in #10117 though, which modifies "make check" to run the test under xvfb if it's available.
ryanofsky closed this on Mar 29, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#10110 make check fails if building qt on a system with no display #10117 Fix "make check" on systems with qt and libxcb but no active DISPLAY