Speed Up CuckooCache tests #10128

pull JeremyRubin wants to merge 1 commits into bitcoin:master from JeremyRubin:cuckoo-tests-faster changing 1 files +7 −6

JeremyRubin commented at 7:34 PM on March 30, 2017: contributor

I decreased all the sizes, should be much faster. Shouldn't impact correctness of the cache or likelihood of catching bugs in the cache.

Can be reverted if we want to do extended tests later.

Addresses https://github.com/bitcoin/bitcoin/issues/10026
Decrease testcase sizes in cuckoocache tests 3f098cccf6
fanquake added the label Tests on Mar 30, 2017

fanquake commented at 1:43 AM on March 31, 2017: member

Tested with src/test/test_bitcoin --log_level=all --run_test=cuckoocache_tests

5 runs of master (edc62c959ab3ed7019b514107a4ab3865fc12c2e):

Leaving test suite "cuckoocache_tests"; testing time: 6987983us
Leaving test suite "cuckoocache_tests"; testing time: 6994218us
Leaving test suite "cuckoocache_tests"; testing time: 6903206us
Leaving test suite "cuckoocache_tests"; testing time: 7051359us
Leaving test suite "cuckoocache_tests"; testing time: 7055289us

avg = ~6998411us

vs 5 runs of this PR (3f098cc):

Leaving test suite "cuckoocache_tests"; testing time: 893674us
Leaving test suite "cuckoocache_tests"; testing time: 884415us
Leaving test suite "cuckoocache_tests"; testing time: 877087us
Leaving test suite "cuckoocache_tests"; testing time: 906258us
Leaving test suite "cuckoocache_tests"; testing time: 896657us

avg = ~891618us

= ~8times speedup

paveljanik commented at 10:04 AM on March 31, 2017: contributor

ACK https://github.com/bitcoin/bitcoin/pull/10128/commits/3f098cccf618557ccf1ce8a51f88819d89f29208
gmaxwell approved
gmaxwell commented at 7:37 PM on April 1, 2017: contributor

utACK
laanwj merged this on Apr 2, 2017
laanwj closed this on Apr 2, 2017
laanwj referenced this in commit 427d2fd04e on Apr 2, 2017
PastaPastaPasta referenced this in commit 6a666bb300 on May 10, 2019
PastaPastaPasta referenced this in commit b1905fba56 on May 15, 2019
PastaPastaPasta referenced this in commit 818ec218d6 on May 20, 2019
PastaPastaPasta referenced this in commit aae36f83b1 on May 21, 2019
barrystyle referenced this in commit 4c4201ebb3 on Jan 22, 2020
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#10026 Overview of slow unit tests