Run bitcoin_test-qt under minimal QPA platform #10142

pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/qtmin changing 3 files +22 −0

ryanofsky commented at 3:17 PM on April 3, 2017: member

Fixes broken "make check" reported by @TheBlueMatt in #10110

Fix was suggested and initially implemented by @theuni in #10117 (comment)

Run bitcoin_test-qt under minimal QPA platform

Fixes broken "make check" reported by Matt Corallo <git@bluematt.me> in
https://github.com/bitcoin/bitcoin/issues/10110

Fix was suggested and initially implemented by
Cory Fields <cory-nospam-@coryfields.com> in
https://github.com/bitcoin/bitcoin/pull/10117#issuecomment-290275236

bf1026412d

laanwj commented at 4:13 PM on April 3, 2017: member

Concept ACK
fanquake added the label Tests on Apr 3, 2017
sipa commented at 7:09 AM on April 4, 2017: member

Concept ACK
laanwj commented at 9:21 AM on April 6, 2017: member

@TheBlueMatt can you check if this solves your issue #10110?
in src/qt/test/wallettests.cpp:73 in bf1026412d
```
  67 | @@ -68,6 +68,18 @@ QModelIndex FindTx(const QAbstractItemModel& model, const uint256& txid)
  68 |  }
  69 |  
  70 |  //! Simple qt wallet tests.
  71 | +//
  72 | +// Test widgets can be debugged interactively calling show() on them and
  73 | +// manually running the event loop, e.g.:
```
theuni commented at 5:45 PM on April 6, 2017:

Can this be done automatically based on the platform selected? Or does it require manual placement of the .show()s? If not, that would at least make it so that you can avoid a recompile for debug cycles.

ryanofsky commented at 7:13 PM on April 6, 2017:

Can this be done automatically

It would probably be possible to test code that would show all widgets. So far I've found it useful just to show selected widgets when debugging.

laanwj commented at 3:11 PM on April 7, 2017:

As I understand it the issues troubleshooted here are rare enough that it's fine to have the developer insert his own .show()s at appropriate places. It's just useful to have this comment in that case.
in build-aux/m4/bitcoin_qt.m4:133 in bf1026412d
```
 129 | @@ -130,6 +130,8 @@ AC_DEFUN([BITCOIN_QT_CONFIGURE],[
 130 |        if test "x$bitcoin_cv_need_acc_widget" = "xyes"; then
 131 |          _BITCOIN_QT_CHECK_STATIC_PLUGINS([Q_IMPORT_PLUGIN(AccessibleFactory)], [-lqtaccessiblewidgets])
 132 |        fi
 133 | +      _BITCOIN_QT_CHECK_STATIC_PLUGINS([Q_IMPORT_PLUGIN(QMinimalIntegrationPlugin)],[-lqminimal])
```
theuni commented at 5:49 PM on April 6, 2017:

We need to make it so that this doesn't signal failed qt detection if libqminimal isn't found. It'd be fine if it were just test_bitcoin-qt disabled, but this would also disable the bitcoin-qt build which has no dependency on the lib.

ryanofsky commented at 7:07 PM on April 6, 2017:

We need to make it so that this doesn't signal failed qt detection if libqminimal isn't found.

What should happen if minimal isn't found, and why we can't just make it a requirement? I looked into trying making it make it optional, but it seemed like a mess, see my comment #10117 (comment)
theuni changes_requested
theuni commented at 5:50 PM on April 6, 2017: member

Concept ACK and ACK after fixing up the configure check.
theuni commented at 5:51 PM on April 6, 2017: member

@laanwj I can confirm that it does, I'm seeing the issue locally as well.
jonasschnelli commented at 6:45 PM on April 9, 2017: contributor

Tested ACK on debian 8 with Qt5.3 headless: bf1026412da73b13ada3b4543e88938057362eb7
laanwj commented at 7:01 AM on April 10, 2017: member

Thanks for testing. Then I'm going to merge this to prevent test failures for affected devs; the build system integration can be improved later.
laanwj merged this on Apr 10, 2017
laanwj closed this on Apr 10, 2017
laanwj referenced this in commit ed09dd3f5a on Apr 10, 2017
ryanofsky referenced this in commit e4bc19f6f8 on Jun 2, 2017
PastaPastaPasta referenced this in commit 9f6ef77733 on May 6, 2019
PastaPastaPasta referenced this in commit f8c3f9f7d1 on May 6, 2019
barrystyle referenced this in commit 4c9c8fca40 on Jan 22, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#10110 make check fails if building qt on a system with no display #10117 Fix "make check" on systems with qt and libxcb but no active DISPLAY #10509 Remove xvfb configuration from travis