Include cleanup #10181

pull jtimon wants to merge 2 commits into bitcoin:master from jtimon:2017-04-10-includes changing 11 files +10 −3

jtimon commented at 2:13 AM on April 11, 2017: contributor

Continues #5697

I'm very open to squash anything, separate foreach into a different PR or some other suggestion that it's mostly include-only.

Less to catch these days, that's a good sign Related branch: https://github.com/jtimon/bitcoin/commits/long-globals
fanquake added the label Refactoring on Apr 11, 2017
paveljanik commented at 9:08 PM on April 11, 2017: contributor

ACK https://github.com/bitcoin/bitcoin/pull/10181/commits/7c5d13c160594fd67c7751dbe2c52f6697c71f40

Nice!
practicalswift commented at 9:24 PM on April 11, 2017: contributor

Good stuff!

utACK 7c5d13c160594fd67c7751dbe2c52f6697c71f40
in src/net.h:37 in 856d012bf3 outdated
```
  32 | @@ -34,9 +33,7 @@
  33 |  #endif
  34 |  
  35 |  #include <boost/foreach.hpp>
  36 | -#include <boost/signals2/signal.hpp>
```
TheBlueMatt commented at 9:34 PM on April 11, 2017:

I'm not convinced this is OK. We use signals in CNodeSignals a bit later down in this file. I think you're using the indirect include from addrman -> util.

Trivial: Remove unneeded includes from .h:

- validation.h doesn't need to include chain.h anymore
- Remove unneeded includes from net.h

a1fd450328

Missing includes 1c897fc3da
jtimon force-pushed on Apr 13, 2017
jtimon commented at 12:34 AM on April 13, 2017: contributor

Fixed @TheBlueMatt 's nit and removed the commit dealing with boost/foreach.hpp since that's dealt with differently but more completely in #10193.
dcousens approved
laanwj merged this on Apr 20, 2017
laanwj closed this on Apr 20, 2017
laanwj referenced this in commit 86ea3c2ff2 on Apr 20, 2017
jtimon deleted the branch on Apr 20, 2017
PastaPastaPasta referenced this in commit 4bfea5ac80 on May 21, 2019
PastaPastaPasta referenced this in commit 7f2769d50c on May 21, 2019
PastaPastaPasta referenced this in commit 35db85c53c on May 22, 2019
PastaPastaPasta referenced this in commit 9640f57ceb on May 22, 2019
PastaPastaPasta referenced this in commit efef8e7549 on May 22, 2019
PastaPastaPasta referenced this in commit b611e447b5 on May 22, 2019
PastaPastaPasta referenced this in commit d896c81b04 on May 23, 2019
PastaPastaPasta referenced this in commit 8368feebed on May 28, 2019
PastaPastaPasta referenced this in commit 56eb4aebb7 on May 28, 2019
PastaPastaPasta referenced this in commit 3469ec3493 on Jun 7, 2019
PastaPastaPasta referenced this in commit 3d46bd3e79 on Jun 8, 2019
PastaPastaPasta referenced this in commit 26e58303ff on Jun 10, 2019
barrystyle referenced this in commit 73ab548080 on Jan 22, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels