[Consensus] Add constant for maximum stack size #10313

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:stackconst changing 2 files +4 −1

instagibbs commented at 3:00 PM on May 2, 2017: member

Currently only used once, but for an important constant like this it seems worthwhile.
in src/script/script.h:33 in 9627e681e7 outdated
```
  29 | @@ -30,6 +30,9 @@ static const int MAX_PUBKEYS_PER_MULTISIG = 20;
  30 |  // Maximum script length in bytes
  31 |  static const int MAX_SCRIPT_SIZE = 10000;
  32 |  
  33 | +// Maximum size of the script interpreter stack
```
ryanofsky commented at 3:24 PM on May 2, 2017:

Maybe mention what the unit is.

instagibbs commented at 5:22 PM on May 2, 2017:

stack units? :)

laanwj commented at 5:25 PM on May 2, 2017:

"maximum number of values on script interpreter stack" maybe
ryanofsky commented at 3:25 PM on May 2, 2017: member

utACK 9627e681e793834b321dcecd155ef130d39b4e69
laanwj added the label Refactoring on May 2, 2017
Add constant for maximum stack size cb184b3a54
instagibbs force-pushed on May 2, 2017
instagibbs commented at 5:38 PM on May 2, 2017: member

updated with nit
practicalswift commented at 8:16 PM on May 2, 2017: contributor

utACK cb184b3a544df7bcc7695ad3b54ed9d196c1650e

Idea for another PR: Add test case triggering SCRIPT_ERR_STACK_SIZE
dcousens approved
ryanofsky commented at 1:35 PM on May 3, 2017: member

utACK cb184b3a544df7bcc7695ad3b54ed9d196c1650e
paveljanik commented at 8:47 AM on May 5, 2017: contributor

ACK cb184b3
ryanofsky commented at 4:43 PM on May 23, 2017: member

This seems like it could be merged, has 3 acks.
sipa commented at 4:45 PM on May 23, 2017: member

utACK cb184b3a544df7bcc7695ad3b54ed9d196c1650e
sipa merged this on May 23, 2017
sipa closed this on May 23, 2017
sipa referenced this in commit 4cb8757aae on May 23, 2017
PastaPastaPasta referenced this in commit c93e4c305b on Jun 10, 2019
PastaPastaPasta referenced this in commit 88f474232c on Jun 11, 2019
PastaPastaPasta referenced this in commit eb0bc36398 on Jun 11, 2019
PastaPastaPasta referenced this in commit 194844efc2 on Jun 15, 2019
PastaPastaPasta referenced this in commit e0c01b4f2e on Jun 19, 2019
PastaPastaPasta referenced this in commit 1739b2d610 on Jun 19, 2019
PastaPastaPasta referenced this in commit 1c14adf4a1 on Jun 19, 2019
PastaPastaPasta referenced this in commit 8488acf810 on Jun 19, 2019
PastaPastaPasta referenced this in commit 01255122a6 on Jun 19, 2019
PastaPastaPasta referenced this in commit 7062a72762 on Jun 20, 2019
PastaPastaPasta referenced this in commit d10076a5d1 on Jun 22, 2019
PastaPastaPasta referenced this in commit 8fc7addcab on Jun 22, 2019
PastaPastaPasta referenced this in commit 17b3978d7c on Jun 22, 2019
PastaPastaPasta referenced this in commit a456328b8c on Jun 22, 2019
PastaPastaPasta referenced this in commit d206d41abe on Jun 22, 2019
PastaPastaPasta referenced this in commit 1522230ec1 on Jun 24, 2019
schancel referenced this in commit 74c90dd74f on Jul 5, 2019
jonspock referenced this in commit 7ba8a62bda on Aug 28, 2019
jonspock referenced this in commit 5975bd4d38 on Aug 28, 2019
proteanx referenced this in commit 0b44255538 on Aug 28, 2019
barrystyle referenced this in commit e471b28faa on Jan 22, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels