Update to latest libsecp256k1 master #10323

sipa commented at 2:26 AM on May 3, 2017: member

There have been a few small performance improvements, and improved tests.

laanwj added the label Utils and libraries on May 3, 2017

gmaxwell commented at 11:06 AM on May 3, 2017: contributor

ACK (haven't verified the subtree merge, those always mangle for me)

laanwj commented at 11:56 AM on May 3, 2017: member

Subtree checks out for me, haven't reviewed the secp256k1-changes-ACK

$ git fetch https://github.com/bitcoin-core/secp256k1.git
remote: Counting objects: 209, done.
remote: Total 209 (delta 126), reused 126 (delta 126), pack-reused 83
Receiving objects: 100% (209/209), 97.14 KiB | 0 bytes/s, done.
Resolving deltas: 100% (143/143), completed with 47 local objects.
From https://github.com/bitcoin-core/secp256k1
 * branch            HEAD       -> FETCH_HEAD
$ contrib/devtools/git-subtree-check.sh src/secp256k1
src/secp256k1 in HEAD was last updated to upstream commit cbc20b8c34d44c2ef175420f3cdfe054f82e8e2c (tree 7f745a9ba06199f3d072634b9082f94d47b3ef35)
src/secp256k1 in HEAD currently refers to tree 7f745a9ba06199f3d072634b9082f94d47b3ef35
GOOD

Squashed 'src/secp256k1/' changes from 8225239..84973d3

84973d3 Merge #454: Remove residual parts from the schnorr expirement.
5e95bf2 Remove residual parts from the schnorr expirement.
cbc20b8 Merge #452: Minor optimizations to _scalar_inverse to save 4M
4cc8f52 Merge #437: Unroll secp256k1_fe_(get|set)_b32 to make them much faster.
465159c Further shorten the addition chain for scalar inversion.
a2b6b19 Fix benchmark print_number infinite loop.
8b7680a Unroll secp256k1_fe_(get|set)_b32 for 10x26.
aa84990 Unroll secp256k1_fe_(get|set)_b32 for 5x52.
cf12fa1 Minor optimizations to _scalar_inverse to save 4M
1199492 Merge #408: Add `secp256k1_ec_pubkey_negate` and `secp256k1_ec_privkey_negate`
6af0871 Merge #441: secp256k1_context_randomize: document.
ab31a52 Merge #444: test: Use checked_alloc
eda5c1a Merge #449: Remove executable bit from secp256k1.c
51b77ae Remove executable bit from secp256k1.c
5eb030c test: Use checked_alloc
72d952c FIXUP: Missing "is"
70ff29b secp256k1_context_randomize: document.
9d560f9 Merge #428: Exhaustive recovery
8e48aa6 Add `secp256k1_ec_pubkey_negate` and `secp256k1_ec_privkey_negate`
2cee5fd exhaustive tests: add recovery module
678b0e5 exhaustive tests: remove erroneous comment from ecdsa_sig_sign
03ff8c2 group_impl.h: remove unused `secp256k1_ge_set_infinity` function
a724d72 configure: add --enable-coverage to set options for coverage analysis
b595163 recovery: add tests to cover API misusage
6f8ae2f ecdh: test NULL-checking of arguments
25e3cfb ecdsa_impl: replace scalar if-checks with VERIFY_CHECKs in ecdsa_sig_sign

git-subtree-dir: src/secp256k1
git-subtree-split: 84973d393ac240a90b2e1a6538c5368202bc2224

e7c1b4490f

Update to latest libsecp256k1 525282769e

sipa force-pushed on May 5, 2017

sipa commented at 6:13 PM on May 5, 2017: member

Updated to also include https://github.com/bitcoin-core/secp256k1/pull/454.

gmaxwell approved

gmaxwell commented at 3:07 AM on May 6, 2017: contributor

re-ACK

fanquake commented at 9:02 AM on May 17, 2017: member

Tested the subtree-merge ACK

[pull/10323/local-merge 53b64555f] Merge [#10323](/bitcoin-bitcoin/10323/): Update to latest libsecp256k1 master
 Date: Wed May 17 16:58:22 2017 +0800
[#10323](/bitcoin-bitcoin/10323/) Update to latest libsecp256k1 master into master
* 525282769 Update to latest libsecp256k1 (Pieter Wuille) (pull/10323/head)
* e7c1b4490 Squashed 'src/secp256k1/' changes from 8225239..84973d3 (Pieter Wuille)

Dropping you on a shell so you can try building/testing the merged source.
Run 'git diff HEAD~' to show the changes being merged.
Type 'exit' when done.
bash-3.2$ git fetch https://github.com/bitcoin-core/secp256k1.git
remote: Counting objects: 3934, done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 3934 (delta 0), reused 0 (delta 0), pack-reused 3928
Receiving objects: 100% (3934/3934), 1.61 MiB | 110.00 KiB/s, done.
Resolving deltas: 100% (2762/2762), done.
From https://github.com/bitcoin-core/secp256k1
 * branch                HEAD       -> FETCH_HEAD
bash-3.2$ contrib/devtools/git-subtree-check.sh src/secp256k1
src/secp256k1 in HEAD was last updated to upstream commit 84973d393ac240a90b2e1a6538c5368202bc2224 (tree 0cedbba829a5b38b750b2952af49b45880c32117)
src/secp256k1 in HEAD currently refers to tree 0cedbba829a5b38b750b2952af49b45880c32117
GOOD

laanwj merged this on Jun 2, 2017

laanwj closed this on Jun 2, 2017

laanwj referenced this in commit 00d3692396 on Jun 2, 2017

sipa deleted the branch on Jun 23, 2017

PastaPastaPasta referenced this in commit 18119b5bc4 on Jun 20, 2019

PastaPastaPasta referenced this in commit 2083ec18a6 on Jun 20, 2019

PastaPastaPasta referenced this in commit 3ec9718c45 on Jun 22, 2019

PastaPastaPasta referenced this in commit 72077d4b15 on Jun 22, 2019

PastaPastaPasta referenced this in commit 05035be10a on Jun 22, 2019

PastaPastaPasta referenced this in commit 81451c04dd on Jun 22, 2019

PastaPastaPasta referenced this in commit 41288881b2 on Jun 22, 2019

PastaPastaPasta referenced this in commit 37c735fbdd on Jun 22, 2019

PastaPastaPasta referenced this in commit 796f1656c5 on Jun 22, 2019

PastaPastaPasta referenced this in commit c04f52f192 on Jun 22, 2019

PastaPastaPasta referenced this in commit 0dfb12d957 on Jun 22, 2019

PastaPastaPasta referenced this in commit 3895d3868f on Jun 22, 2019

PastaPastaPasta referenced this in commit c7aa3723c7 on Jun 26, 2019

barrystyle referenced this in commit 4d3ed6b6e5 on Jan 22, 2020

DrahtBot locked this on Sep 8, 2021