Use range-based for loops (C++11) when looping over vector elements #10346

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:range-based-for-loops changing 5 files +29 −31

practicalswift commented at 9:06 PM on May 5, 2017: contributor

No description provided.
Use range-based for loops (C++11) when looping over vector elements a1c38a3a95

in src/wallet/wallet.cpp:1785 in a1c38a3a95

1780 | @@ -1781,8 +1781,8 @@ bool CWalletTx::IsEquivalentTo(const CWalletTx& _tx) const
1781 |  {
1782 |          CMutableTransaction tx1 = *this->tx;
1783 |          CMutableTransaction tx2 = *_tx.tx;
1784 | -        for (unsigned int i = 0; i < tx1.vin.size(); i++) tx1.vin[i].scriptSig = CScript();
1785 | -        for (unsigned int i = 0; i < tx2.vin.size(); i++) tx2.vin[i].scriptSig = CScript();
1786 | +        for (auto txIn : tx1.vin) txIn.scriptSig = CScript();
1787 | +        for (auto txIn : tx2.vin) txIn.scriptSig = CScript();

ryanofsky commented at 9:14 PM on May 5, 2017:

These need to be auto& to have an an effect. Probably all the auto declarations here should be replaced by auto& or const auto&

practicalswift commented at 9:41 PM on May 5, 2017:

Was a bit too fast with submitting this - sorry about that. Closed this PR and cannot re-open. New correct PR submitted.

practicalswift closed this on May 5, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

practicalswift

ryanofsky