Use range-based for loops (C++11) when looping over vector elements #10347

1141 | @@ -1142,24 +1142,24 @@ class CTransactionSignatureSerializer {
1142 |  
1143 |  uint256 GetPrevoutHash(const CTransaction& txTo) {
1144 |      CHashWriter ss(SER_GETHASH, 0);
1145 | -    for (unsigned int n = 0; n < txTo.vin.size(); n++) {
1146 | -        ss << txTo.vin[n].prevout;
1147 | +    for (const auto& txIn : txTo.vin) {

---

1780 | @@ -1781,8 +1781,8 @@ bool CWalletTx::IsEquivalentTo(const CWalletTx& _tx) const
1781 |  {
1782 |          CMutableTransaction tx1 = *this->tx;
1783 |          CMutableTransaction tx2 = *_tx.tx;
1784 | -        for (unsigned int i = 0; i < tx1.vin.size(); i++) tx1.vin[i].scriptSig = CScript();
1785 | -        for (unsigned int i = 0; i < tx2.vin.size(); i++) tx2.vin[i].scriptSig = CScript();
1786 | +        for (const auto& txIn : tx1.vin) txIn.scriptSig = CScript();

---

3057 | @@ -3058,8 +3058,8 @@ bool ContextualCheckBlock(const CBlock& block, CValidationState& state, const Co
3058 |  
3059 |      // No witness data is allowed in blocks that don't commit to witness data, as this would otherwise leave room for spam
3060 |      if (!fHaveWitness) {
3061 | -        for (size_t i = 0; i < block.vtx.size(); i++) {
3062 | -            if (block.vtx[i]->HasWitness()) {
3063 | +      for (const auto& transactionRef : block.vtx) {

---

2148 | @@ -2149,10 +2149,10 @@ bool CWallet::SelectCoinsMinConf(const CAmount& nTargetValue, const int nConfMin
2149 |  
2150 |      if (nTotalLower == nTargetValue)
2151 |      {
2152 | -        for (unsigned int i = 0; i < vValue.size(); ++i)
2153 | +        for (const auto& inputCoin : vValue)

---