[tests] Add abortrescan RPC test #11314

pull mess110 wants to merge 1 commits into bitcoin:master from mess110:add-abortrescan-rpc-test changing 1 files +2 −0

mess110 commented at 11:50 PM on September 12, 2017: contributor

I opted for testing only the interface existence, since I don't think the RPC can be tested in a sane and clean way (please advise otherwise).

This is the last RPC method which was missing coverage when running the extended tests :)
Add abortrescan RPC test 2184404cff
mess110 renamed this:
~~Add abortrescan RPC test~~
[tests] Add abortrescan RPC test
on Sep 12, 2017
fanquake added the label Tests on Sep 12, 2017
in test/functional/import-rescan.py:182 in 2184404cff
```
 178 | @@ -179,6 +179,8 @@ def run_test(self):
 179 |              else:
 180 |                  variant.check()
 181 |  
 182 | +        assert_equal(try_rpc(self.nodes[0].abortrescan)[1], None)
```
promag commented at 1:27 PM on September 13, 2017:

I believe there is no need to try_rpc since abortrescan returns bool. For that reason, add 2 tests, one for each return value.
MarcoFalke commented at 1:33 PM on September 13, 2017: member

Related to #10367
jnewbery commented at 3:26 PM on September 13, 2017: member

I'm not sure this adds much value. I'd much rather see #10367 worked on and merged (I had some problems running that test in the past, but it may have just been my local environment)
mess110 commented at 3:45 PM on September 13, 2017: contributor

I was thinking threading would over complicate the test, so I only tested the interface. Ok, will check that one.
mess110 closed this on Sep 13, 2017
mess110 deleted the branch on Sep 14, 2017
mess110 cross-referenced this on Sep 14, 2017 from issue [test] Test abortrescan command by mess110
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#10367 [WIP] [test] Test abortrescan command.#11329 [test] Test abortrescan command