[test] Test abortrescan command #11329

pull mess110 wants to merge 2 commits into bitcoin:master from mess110:kallewoof/test-abort-rescan-2 changing 2 files +77 −0

mess110 commented at 4:28 PM on September 14, 2017: contributor

This is an attempt of continuing the #10367 PR started by @kallewoof.

Got here through #11314

I really hope, I am not overstepping by submitting this PR, I tried to contact @kallewoof, but the user is not on slack. Since the PR was opened in May, I decided to try to help to improve it.

I addressed the nits mentioned and added the test for False
[test] Test abortrescan command. fef5ec5f84
fix mentioned nits and test for False 516944a575
instagibbs commented at 4:55 PM on September 14, 2017: member

@mess110 Typically try to contact the user on IRC(or just ask on freenode #bitcoin-core-dev), people will help you find out.
fanquake added the label Tests on Sep 14, 2017
laanwj commented at 2:29 PM on September 15, 2017: member

I really hope, I am not overstepping by submitting this PR, I tried to contact @kallewoof, but the user is not on slack. Since the PR was opened in May, I decided to try to help to improve it.

No problem! you're always free to continue an issue if it has been abandoned for a while and you want to help it forward. Thanks! If @kallewoof wants he can cherry-pick this into #10367, if not we can continue development here.
kallewoof commented at 2:41 AM on September 19, 2017: member

I've definitely not abandoned it, and not sure why you would get that impression. I'll review your commits and cherry pick if they look good later today.
mess110 commented at 7:42 AM on September 19, 2017: contributor

Work continuing on the prev PR, closing this one
mess110 closed this on Sep 19, 2017
mess110 deleted the branch on Sep 19, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#10367 [WIP] [test] Test abortrescan command.#11314 [tests] Add abortrescan RPC test