No description provided.
Replace boost::function with std::function (C++11) #10395
pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:replace-boost-function changing 11 files +26 −30-
practicalswift commented at 3:55 PM on May 13, 2017: contributor
-
Replace boost::function with std::function (C++11) 1b936f5926
- practicalswift force-pushed on May 13, 2017
- dcousens approved
-
MarcoFalke commented at 10:42 AM on May 14, 2017: member
utACK 1b936f59264a4f4a867baece1e0ee4ec02f73cee
- MarcoFalke added the label Refactoring on May 14, 2017
-
sipa commented at 6:31 PM on May 14, 2017: member
utACK 1b936f59264a4f4a867baece1e0ee4ec02f73cee
- fanquake added this to the "In progress" column in a project
-
in src/bench/bench.cpp:8 in 1b936f5926
4 | @@ -5,6 +5,7 @@ 5 | #include "bench.h" 6 | #include "perf.h" 7 | 8 | +#include <assert.h>
paveljanik commented at 6:37 AM on May 15, 2017:How is this hunk (including
assert.h) connected with "Replace boost::function with std::function (C++11)"?
practicalswift commented at 8:29 AM on May 15, 2017:@paveljanik That is a very good question! Surprisingly it seems like
#include <boost/function.hpp>give youassertandlimitstoo.Compiling without
#include <assert.h>insrc/bench/bench.cpp:CXX bench/bench_bench_bitcoin-bench.o bench/bench.cpp: In member function ‘bool benchmark::State::KeepRunning()’: bench/bench.cpp:95:86: error: ‘assert’ was not declared in this scope assert(count != 0 && "count == 0 => (now == 0 && beginTime == 0) => return above");Compiling without
#include <limits>insrc/bench/bench.h:CXX bench/bench_bench_bitcoin-bench_bitcoin.o In file included from bench/bench_bitcoin.cpp:5:0: bench/bench.h: In constructor ‘benchmark::State::State(std::__cxx11::string, double)’: bench/bench.h:52:23: error: ‘numeric_limits’ is not a member of ‘std’ minTime = std::numeric_limits<double>::max(); ^
paveljanik commented at 9:03 AM on May 15, 2017:Perfect answer, thanks! I should have tested it myself 8)
paveljanik approvedpaveljanik commented at 7:06 AM on May 15, 2017: contributorACK
fanquake commented at 8:44 AM on May 17, 2017: memberutACK 1b936f5
sipa merged this on May 18, 2017sipa closed this on May 18, 2017sipa referenced this in commit c33652576c on May 18, 2017fanquake moved this from the "In progress" to the "Done" column in a project
PastaPastaPasta referenced this in commit 42db6c7987 on Jun 10, 2019PastaPastaPasta referenced this in commit dbcc421d56 on Jun 11, 2019PastaPastaPasta referenced this in commit 91bf767dbb on Jun 11, 2019PastaPastaPasta referenced this in commit acb2b5450d on Jun 15, 2019PastaPastaPasta referenced this in commit 4f472a8283 on Jun 19, 2019PastaPastaPasta referenced this in commit 8713704f68 on Jun 19, 2019PastaPastaPasta referenced this in commit 67eaf393aa on Jun 19, 2019PastaPastaPasta referenced this in commit 929ee02a2f on Jun 19, 2019PastaPastaPasta referenced this in commit 6a17bf7531 on Jun 19, 2019PastaPastaPasta referenced this in commit 4f810adfb8 on Jun 20, 2019PastaPastaPasta referenced this in commit 3eeb2fd016 on Jun 22, 2019PastaPastaPasta referenced this in commit e4fadfd401 on Jun 22, 2019PastaPastaPasta referenced this in commit d3d11be195 on Jun 22, 2019PastaPastaPasta referenced this in commit 0ecacd8ae2 on Jun 22, 2019PastaPastaPasta referenced this in commit fdec4ab081 on Jun 22, 2019PastaPastaPasta referenced this in commit 2e050ea744 on Jun 24, 2019barrystyle referenced this in commit ca06646f95 on Jan 22, 2020zkbot referenced this in commit aa225ebb0b on Jan 24, 2020zkbot referenced this in commit 74ff73abab on Jan 24, 2020zkbot referenced this in commit d331325d28 on Feb 7, 2020zkbot referenced this in commit a2d719b9ff on Feb 7, 2020furszy referenced this in commit 4ed15cc69d on Jun 8, 2020practicalswift deleted the branch on Apr 10, 2021DrahtBot locked this on Aug 18, 2022Labels
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-16 15:15 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-16 15:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me