[trivial] Fix three recently introduced typos #10419

1. 
   practicalswift commented at 7:52 am on May 18, 2017: contributor

   Typos introduced in 3810e976 and 2d2e1705 which were merged into master as part of #10199 twelve hours ago:

   0$ git blame src/policy/fees.cpp | grep becuase
   13810e976 (2017-03-07 11:33:44 -0500 789)          * checks for 2*target becuase we are taking the max over all time
   2$ git blame src/policy/fees.h | grep successfullly
   32d2e1705 (2017-04-12 12:29:03 -0400  54)  * representing that a tx was successfullly confirmed in less than or equal to
   

   Friendly ping @morcos :-)

2. 
   paveljanik commented at 7:55 am on May 18, 2017: contributor

   ACK https://github.com/bitcoin/bitcoin/pull/10419/commits/6516a9fcb1f0190564fba4b24837c5942ed5788a
3. 
   fanquake commented at 8:03 am on May 18, 2017: member

   trivial ACK 6516a9f

   Im curious. What tool are you using to find these? I assume it’s being run in some automated way on the repository when new changes are merged? Why not merge the open pull requests instead, catch the typos/incorrect includes etc etc and then advise changes in the PRs while they are still open?

4. fanquake added the label Docs and Output on May 18, 2017
5. 
   practicalswift commented at 10:40 am on May 18, 2017: contributor

   @fanquake I’ve written a bunch of custom scripts that help me identify potential issues. These cover the spectra from identifying trivial typos to running and triaging output from clang-tidy and similar tools. However, the cleanup work is all manual. See my gardening efforts in the Apple Swift project for examples of issues covered by my gardening toolkit.

   For various reasons the Swift project is a bit more strict (i.e. near zero tolerance towards clang-tidy violations, full PEP-8 compliance, etc.), so I’m using a more relaxed subset of the same toolkit when gardening the Bitcoin project :-)

   Unfortunately the toolkit work flow does not yet support checking not-yet-merged pull requests easily, but that is something I would like to add in the future :-)

6. 
   morcos commented at 11:59 am on May 18, 2017: member

   (sigh at myself) ACK
7. 
   jtimon commented at 10:28 pm on May 22, 2017: contributor

   ACK 6516a9fcb1f0190564fba4b24837c5942ed5788a

   EDIT: thanks for documenting the introductions for “traceability”

8. [trivial] Fix three recently introduced typos

   ```
   $ git blame src/policy/fees.cpp | grep becuase
   3810e976 (2017-03-07 11:33:44 -0500 789)          * checks for 2*target becuase we are taking the max over all time
   $ git blame src/policy/fees.h | grep successfullly
   2d2e1705 (2017-04-12 12:29:03 -0400  54)  * representing that a tx was successfullly confirmed in less than or equal to
   $ git blame src/wallet/feebumper.cpp | grep "hasen't"
   a3878374 (2017-05-11 09:34:39 +0200 258)     // make sure the transaction still has no descendants and hasen't been mined in the meantime
   ```

   efc2e3302d
9. practicalswift force-pushed on May 23, 2017
10. 
    practicalswift commented at 11:23 am on May 23, 2017: contributor

    Fixed another typo:

    0$ git blame src/wallet/feebumper.cpp | grep "hasen't"
    1a3878374 (2017-05-11 09:34:39 +0200 258)     // make sure the transaction still has no descendants and hasen't been mined in the meantime
    

    Friendly ping @jonasschnelli :-)

11. practicalswift renamed this:
    [trivial] Fix two recently introduced typos
    [trivial] Fix three recently introduced typos
    on May 23, 2017
12. 
    jtimon commented at 1:25 pm on May 23, 2017: contributor

    re-utACK efc2e3302d9df87bca5116f15bcbee000ccfb67f
13. 
    paveljanik commented at 9:30 am on May 26, 2017: contributor

    reACK https://github.com/bitcoin/bitcoin/commit/efc2e3302d9df87bca5116f15bcbee000ccfb67f
14. sipa merged this on May 26, 2017
15. sipa closed this on May 26, 2017

    ---

16. sipa referenced this in commit b40ceed98a on May 26, 2017
17. PastaPastaPasta referenced this in commit f4312580b2 on Jul 17, 2019
18. PastaPastaPasta referenced this in commit 2e47dd8781 on Jul 17, 2019
19. PastaPastaPasta referenced this in commit cddcf79767 on Jul 23, 2019
20. PastaPastaPasta referenced this in commit d76cd903e4 on Jul 24, 2019
21. barrystyle referenced this in commit 8cc2508704 on Jan 22, 2020
22. practicalswift deleted the branch on Apr 10, 2021
23. DrahtBot locked this on Aug 18, 2022

Contributors
practicalswift paveljanik fanquake morcos jtimon

Labels
Docs