[qt] Remove excess logic: Prefer "return foo;" to "if (foo) { return true; } else { return false; }" #10421

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:if-expr-return-true-else-return-false changing 1 files +1 −3

practicalswift commented at 4:36 PM on May 18, 2017: contributor
Replace …
```
if (foo) { return true; } else { return false; }
```
… with the equivalent …
```
return foo;
```
The code was introduced in fbf385cc830df2aec7cdcbab0c2b09b46569e8c1 which was merged into master earlier today.

Friendly ping @jonasschnelli :-)
laanwj added the label Refactoring on May 18, 2017
laanwj commented at 6:13 PM on May 18, 2017: member

Can you please add somewhat more description to your commit message and PR? Please don't just drop PRs without any description or motivation.
practicalswift renamed this:
~~[qt] Remove excess logic~~
[qt] Remove excess logic: Prefer "return foo;" to "if (foo) { return true; } else { return false; }"
on May 18, 2017

[qt] Remove excess logic

Replace …

```
if (foo) { return true; } else { return false; }
```

… with the equivalent …

```
return foo;
```

e49b868cfe

practicalswift force-pushed on May 18, 2017
practicalswift commented at 6:51 PM on May 18, 2017: contributor

@laanwj Fixed :-)
jonasschnelli commented at 7:00 PM on May 18, 2017: contributor

ACK e49b868cfe9391ec61b4fedef9811a4be265525d
paveljanik commented at 7:18 PM on May 18, 2017: contributor

utACK e49b868
fanquake commented at 11:45 PM on May 18, 2017: member

utACK e49b868
laanwj merged this on May 23, 2017
laanwj closed this on May 23, 2017
laanwj referenced this in commit 433c57aa6f on May 23, 2017
practicalswift deleted the branch on Apr 10, 2021
DrahtBot locked this on Aug 18, 2022

Contributors

Labels