Remove 33 unused Boost includes #10546

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:remove-unused-boost-includes changing 28 files +0 −40

practicalswift commented at 9:45 AM on June 7, 2017: contributor

Remove 33 unused Boost includes.
practicalswift renamed this:
~~Remove unused Boost includes~~
Remove 38 unused Boost includes
on Jun 7, 2017
fanquake added the label Refactoring on Jun 7, 2017

in src/util.cpp:81 in d399e1b1cf outdated

  76 | @@ -77,11 +77,7 @@
  77 |  #endif
  78 |  
  79 |  #include <boost/algorithm/string/case_conv.hpp> // for to_lower()
  80 | -#include <boost/algorithm/string/join.hpp>
  81 | -#include <boost/algorithm/string/predicate.hpp> // for startswith() and endswith()

fanquake commented at 9:55 AM on June 7, 2017:

starts_with() is still used.

practicalswift commented at 10:03 AM on June 7, 2017:

Good catch! Fixed!

practicalswift force-pushed on Jun 7, 2017
practicalswift renamed this:
~~Remove 38 unused Boost includes~~
Remove 37 unused Boost includes
on Jun 7, 2017
dcousens approved
paveljanik commented at 7:33 PM on June 7, 2017: contributor

compiles ACK https://github.com/bitcoin/bitcoin/pull/10546/commits/d652c7515bbae6d51470cf5ee538b0d5cad9547f

195 more #include <boost/.*> to go!
jonasschnelli commented at 7:25 AM on June 8, 2017: contributor

Gitian builds this fine: https://bitcoin.jonasschnelli.ch/build/166 ACK d652c7515bbae6d51470cf5ee538b0d5cad9547f
practicalswift force-pushed on Jun 8, 2017
practicalswift commented at 7:18 PM on June 8, 2017: contributor

Merge conflicts resolved!
practicalswift force-pushed on Jun 8, 2017
practicalswift force-pushed on Jun 8, 2017
practicalswift force-pushed on Jun 8, 2017
practicalswift force-pushed on Jun 8, 2017
practicalswift renamed this:
~~Remove 37 unused Boost includes~~
Remove 36 unused Boost includes
on Jun 8, 2017

fanquake commented at 1:01 AM on June 9, 2017: member

Builds are failing with

  CXX      wallet/libbitcoin_wallet_a-feebumper.o
In file included from wallet/crypter.cpp:5:0:
wallet/crypter.h:195:5: error: ‘signals2’ in namespace ‘boost’ does not name a type
     boost::signals2::signal<void (CCryptoKeyStore* wallet)> NotifyStatusChanged;
     ^
wallet/crypter.cpp: In member function ‘bool CCryptoKeyStore::Lock()’:
wallet/crypter.cpp:167:29: error: ‘NotifyStatusChanged’ was not declared in this scope
     NotifyStatusChanged(this);
                             ^
wallet/crypter.cpp: In member function ‘bool CCryptoKeyStore::Unlock(const CKeyingMaterial&)’:
wallet/crypter.cpp:205:29: error: ‘NotifyStatusChanged’ was not declared in this scope
     NotifyStatusChanged(this);

practicalswift force-pushed on Jun 9, 2017
practicalswift force-pushed on Jun 9, 2017
Remove unused Boost includes 49de096c2a
practicalswift force-pushed on Jun 9, 2017
practicalswift renamed this:
~~Remove 36 unused Boost includes~~
Remove 33 unused Boost includes
on Jun 9, 2017
practicalswift commented at 1:35 PM on June 9, 2017: contributor

@fanquake Thanks for the notification. Builds now passing!
fanquake commented at 1:54 PM on June 9, 2017: member

utACK 49de096
sipa commented at 7:37 PM on June 9, 2017: member

utACK 49de096c2adcfaf15f99a3355dc4e22f79d56928
laanwj merged this on Jun 11, 2017
laanwj closed this on Jun 11, 2017
laanwj referenced this in commit 2c2d988062 on Jun 11, 2017
PastaPastaPasta referenced this in commit 7d562fdd7b on Jul 5, 2019
PastaPastaPasta referenced this in commit 88b8eb4421 on Jul 5, 2019
PastaPastaPasta referenced this in commit 091d680f73 on Jul 6, 2019
PastaPastaPasta referenced this in commit c10d0b73e3 on Jul 8, 2019
PastaPastaPasta referenced this in commit 4f2f7d9245 on Jul 8, 2019
PastaPastaPasta referenced this in commit 1099c1ad60 on Jul 8, 2019
barrystyle referenced this in commit e35485c7b3 on Jan 22, 2020
zkbot referenced this in commit 40d5f0aa57 on Oct 26, 2020
practicalswift deleted the branch on Apr 10, 2021
DrahtBot locked this on Aug 18, 2022

Contributors

Labels