[tests] Use FastRandomContext instead of boost::random::{mt19937,uniform_int_distribution} #10547

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:remove-boost-random-dependency changing 1 files +4 −6

practicalswift commented at 12:18 PM on June 7, 2017: contributor

Use FastRandomContext instead of boost::random::{mt19937,uniform_int_distribution}.

Was:

Use std::random::mt19937/uniform_int_distribution (C++11) instead of boost::random equivalents.
fanquake added the label Refactoring on Jun 7, 2017
fanquake added the label Tests on Jun 7, 2017
fanquake added this to the "In progress" column in a project

laanwj commented at 12:27 PM on June 7, 2017: member

Why not use our own FastRandomContext? This only uses linear random, so I'd say there's no need to add a dependency on std::random::mt19937.

(though getting rid of the boost one is good...)
practicalswift renamed this:
~~Use std::random::mt19937/uniform_int_distribution (C++11) instead of boost::random equivalents~~
[tests] Use std::random::mt19937/uniform_int_distribution (C++11) instead of boost::random equivalents
on Jun 7, 2017
practicalswift force-pushed on Jun 7, 2017
practicalswift renamed this:
~~[tests] Use std::random::mt19937/uniform_int_distribution (C++11) instead of boost::random equivalents~~
[tests] Use FastRandomContext instead of boost::random::{mt19937,uniform_int_distribution}
on Jun 7, 2017
practicalswift commented at 2:41 PM on June 7, 2017: contributor

@laanwj Good idea! Now using FastRandomContext. Looks OK now?
laanwj commented at 2:46 PM on June 7, 2017: member

Yes, that's a cool minimal-impact solution using the lambda expressions.

in src/test/scheduler_tests.cpp:60 in 27932fb7f4 outdated

  59 | -    boost::random::uniform_int_distribution<> randomMsec(-11, 1000);
  60 | -    boost::random::uniform_int_distribution<> randomDelta(-1000, 1000);
  61 | +    FastRandomContext rng(42);
  62 | +    auto zeroToNine = [](FastRandomContext& rc) { return rc.randrange(10); }; // [0, 9]
  63 | +    auto randomMsec = [](FastRandomContext& rc) { return -11 + rc.randrange(1012); }; // [-11, 1000]
  64 | +    auto randomDelta = [](FastRandomContext& rc) { return -1000 + rc.randrange(2001); }; // [-1000, 1000]

MarcoFalke commented at 4:04 PM on June 7, 2017:

This lambda returns an unsigned expression and such can never be negative.

laanwj commented at 4:22 PM on June 7, 2017:

Good catch, hadn't realized randrange returns an unsigned value. This is a risk with auto.

practicalswift commented at 4:54 PM on June 7, 2017:

@MarcoFalke Oh, good catch! Now explicitly setting the return type. Thanks a lot for noticing!

MarcoFalke changes_requested
practicalswift force-pushed on Jun 7, 2017
[tests] Use FastRandomContext instead of boost::random::{mt19937,uniform_int_distribution} 227ae9b34d
practicalswift force-pushed on Jun 7, 2017
gmaxwell approved
gmaxwell commented at 12:51 AM on June 8, 2017: contributor

utACK
jonasschnelli commented at 6:27 AM on June 8, 2017: contributor

utACK 227ae9b34dce632e42ca9f22139e6efad0485df1. Great use of lambdas.
laanwj merged this on Jun 8, 2017
laanwj closed this on Jun 8, 2017
laanwj referenced this in commit 71ab6e5538 on Jun 8, 2017
fanquake moved this from the "In progress" to the "Done" column in a project

PastaPastaPasta referenced this in commit 285ad02561 on Jul 5, 2019
PastaPastaPasta referenced this in commit 1ddaf38aef on Jul 5, 2019
PastaPastaPasta referenced this in commit 16dbe6edaa on Jul 6, 2019
PastaPastaPasta referenced this in commit b6dc579be8 on Jul 8, 2019
barrystyle referenced this in commit 486ab25565 on Jan 22, 2020
practicalswift deleted the branch on Apr 10, 2021
random-zebra referenced this in commit 0e757ad2c9 on Feb 9, 2022
DrahtBot locked this on Aug 18, 2022

Contributors

Labels