Remove duplicate includes #10561

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:remove-duplicate-includes changing 3 files +0 −4

practicalswift commented at 11:34 PM on June 8, 2017: contributor

Remove duplicate includes.
achow101 commented at 11:39 PM on June 8, 2017: member

utACK 26441d565faf434a9e05884c767b211bf256824e
fanquake added the label Refactoring on Jun 8, 2017
fanquake commented at 12:59 AM on June 9, 2017: member

utACK 26441d5
in src/wallet/rpcwallet.cpp:24 in 26441d565f outdated
```
  20 | @@ -21,7 +21,6 @@
  21 |  #include "timedata.h"
  22 |  #include "util.h"
  23 |  #include "utilmoneystr.h"
  24 | -#include "wallet/coincontrol.h"
```
kallewoof commented at 2:04 AM on June 9, 2017:

Maybe remove the other one instead, to keep the wallet/ imports together?
practicalswift force-pushed on Jun 9, 2017
practicalswift commented at 5:38 AM on June 9, 2017: contributor

@kallewoof Good point! Fixed! :-)
paveljanik commented at 6:25 AM on June 9, 2017: contributor

ACK https://github.com/bitcoin/bitcoin/pull/10561/commits/d7723abfe08937a4cf82ef9dff43e8b36271c7dd

Travis bug unrelated.
kallewoof commented at 6:49 AM on June 9, 2017: member

utACK d7723ab
practicalswift force-pushed on Jun 9, 2017
Remove duplicate includes e53a0fa12a
practicalswift force-pushed on Jun 9, 2017
practicalswift commented at 1:43 PM on June 9, 2017: contributor

Triggered a new Travis build to get rid of the spurious build error.
fanquake commented at 1:55 PM on June 9, 2017: member

re-utACK e53a0fa
sipa commented at 7:57 PM on June 9, 2017: member

utACK e53a0fa12aa998a73abcf6aac07c79c8077c02d4
laanwj merged this on Jun 11, 2017
laanwj closed this on Jun 11, 2017
laanwj referenced this in commit e4918316d8 on Jun 11, 2017
PastaPastaPasta referenced this in commit e492a5e2d9 on Jul 5, 2019
PastaPastaPasta referenced this in commit b1b1a0515d on Jul 5, 2019
PastaPastaPasta referenced this in commit 261291f2a5 on Jul 6, 2019
PastaPastaPasta referenced this in commit 5c77311833 on Jul 8, 2019
PastaPastaPasta referenced this in commit 80b8032501 on Jul 8, 2019
barrystyle referenced this in commit e347312c0d on Jan 22, 2020
practicalswift deleted the branch on Apr 10, 2021
DrahtBot locked this on Aug 18, 2022

Contributors

Labels