Remove safe mode #10563

1. 
   achow101 commented at 1:06 am on June 9, 2017: member

   Rationale:

   Safe mode is useless. It only disables some RPC commands when large work forks are detected. Nothing else is affected by safe mode. It seems that very few people would be affected by safe mode. The people who use Core as a wallet are primarily using it through the GUI, which safe mode does not effect. In the GUI, transactions will still be made as normal; only a warning is displayed.

   I also don’t think that we should be disabling RPC commands or any functionality in general. If we do, it should be done consistently, which safe mode is not. If we want to keep the idea of a safe mode around, I think that the current system needs to go first before a new system can be implemented.

2. fanquake added the label Refactoring on Jun 9, 2017
3. 
   gmaxwell commented at 1:55 am on June 9, 2017: contributor

   Hm! It’s not clear if we should be removing this, or making it better, or removing it as a first step in making it better.

   I think it’s desirable to have your wallet be able to fail-safe when it has detected something awful is going on with the network. Right now this ability is underused and inconsistent.

4. 
   achow101 commented at 2:03 am on June 9, 2017: member

   I should probably be made better, but its current state, IMO, isn’t very useful. It only disables a couple of RPC commands in the event of a large fork (and detection of those are apparently broken - see #9443). The wallet itself and the GUI (which most users use) don’t actually do anything when safe mode is triggered. All they do is display a warning about the large work fork that it has detected.
5. 
   laanwj commented at 11:11 am on June 9, 2017: member

   You don’t provide any rationale. As is, NACK.

   Concept ACK

6. 
   achow101 commented at 5:50 pm on June 9, 2017: member

   @laanwj I added some rationale in the first post.
7. achow101 force-pushed on Jun 19, 2017
8. laanwj added the label RPC/REST/ZMQ on Jul 25, 2017
9. laanwj added this to the milestone 0.16.0 on Jul 25, 2017
10. 
    laanwj commented at 12:20 pm on July 25, 2017: member

    What to do with safe mode should be discussed some time before 0.16.
11. 
    jgarzik commented at 3:44 pm on July 25, 2017: contributor

    concept ACK
12. 
    TheBlueMatt commented at 7:09 pm on July 25, 2017: member

    Yea, I really think this should be improved, not removed, but should be discussed in a meeting, likely.
13. achow101 force-pushed on Aug 15, 2017
14. 
    achow101 commented at 9:53 pm on August 15, 2017: member

    rebased
15. achow101 force-pushed on Aug 16, 2017
16. achow101 force-pushed on Aug 17, 2017
17. in src/rpc/blockchain.cpp:1536 in dc3f8699d3 outdated

    1552-    { "blockchain",         "gettxoutsetinfo",        &gettxoutsetinfo,        true,  {} },
    1553-    { "blockchain",         "pruneblockchain",        &pruneblockchain,        true,  {"height"} },
    1554-    { "blockchain",         "verifychain",            &verifychain,            true,  {"checklevel","nblocks"} },
    1555-
    1556-    { "blockchain",         "preciousblock",          &preciousblock,          true,  {"blockhash"} },
    1557+{ //  category              name                      actor (function)         argNames
    

    ---

    ---

    

    laanwj commented at 12:33 pm on August 28, 2017:

    I really like how this cleans up the dispatch tables, so I’ve filed #11179 which takes that part already.
18. laanwj referenced this in commit e0e3cbbf08 on Sep 5, 2017
19. 
    MarcoFalke commented at 5:09 pm on September 5, 2017: member

    Needs rebase if still relevant.
20. Remove Safe mode 809519da9a
21. achow101 force-pushed on Sep 5, 2017
22. 
    achow101 commented at 7:49 pm on September 5, 2017: member

    Rebased (rewritten really).
23. laanwj removed this from the milestone 0.16.0 on Oct 2, 2017
24. laanwj added this to the milestone Future on Oct 2, 2017
25. 
    laanwj commented at 1:13 pm on April 26, 2018: member

    Probably we should just push forward with this for 0.17.0.
26. MarcoFalke removed this from the milestone Future on Apr 26, 2018
27. MarcoFalke added this to the milestone 0.17.0 on Apr 26, 2018
28. 
    laanwj commented at 1:35 pm on April 26, 2018: member

    Opened rebased version as #13090
29. laanwj closed this on Apr 26, 2018

    ---

30. MarcoFalke removed this from the milestone 0.17.0 on Apr 26, 2018
31. laanwj referenced this in commit 17266a1306 on Apr 27, 2018
32. PastaPastaPasta referenced this in commit 8333834ba6 on Sep 19, 2019
33. PastaPastaPasta referenced this in commit 1f901a183b on Sep 19, 2019
34. PastaPastaPasta referenced this in commit dac32edd38 on Sep 23, 2019
35. PastaPastaPasta referenced this in commit 6886855c4f on Sep 24, 2019
36. PastaPastaPasta referenced this in commit 4bce5f1364 on Nov 19, 2019
37. PastaPastaPasta referenced this in commit 21116f9a30 on Nov 21, 2019
38. PastaPastaPasta referenced this in commit f95269fd92 on Dec 9, 2019
39. PastaPastaPasta referenced this in commit 6e3c4f1cbd on Jan 1, 2020
40. PastaPastaPasta referenced this in commit 7279aba8da on Jan 2, 2020
41. PastaPastaPasta referenced this in commit 5be58aa8f4 on Jan 2, 2020
42. PastaPastaPasta referenced this in commit 1c4757b707 on Jan 2, 2020
43. PastaPastaPasta referenced this in commit 4d8a9cb294 on Jan 2, 2020
44. PastaPastaPasta referenced this in commit d059a9f91b on Jan 2, 2020
45. PastaPastaPasta referenced this in commit 02568d9104 on Jan 2, 2020
46. PastaPastaPasta referenced this in commit 09ed6a45e1 on Jan 3, 2020
47. PastaPastaPasta referenced this in commit bfb100bdd8 on Jun 17, 2020
48. PastaPastaPasta referenced this in commit 0ab2f79f53 on Jun 27, 2020
49. ckti referenced this in commit db1810df8e on Mar 28, 2021
50. gades referenced this in commit 3434ead3db on Jun 30, 2021
51. MarcoFalke locked this on Sep 8, 2021

Contributors
achow101 gmaxwell laanwj jgarzik TheBlueMatt MarcoFalke

Labels
Refactoring RPC/REST/ZMQ