Superset of #10559
This removes the possibility for GetCoin/HaveCoin/HaveCoinInCache to return true while the respective coin is spent. By doing it across all calls, some extra checks can be eliminated.
coins_tests is modified to call HaveCoin sometimes before and sometimes after AccessCoin. A further change is needed because the semantics for GetCoin slightly changed, causing a pruned entry in the parent cache to not be pulled into the child in FetchCoin.
146+ bool result_havecoin = test_havecoin ? stack.back()->HaveCoin(COutPoint(txid, 0)) : false;
147 const Coin& entry = (InsecureRandRange(500) == 0) ? AccessByTxid(*stack.back(), txid) : stack.back()->AccessCoin(COutPoint(txid, 0));
148 BOOST_CHECK(coin == entry);
149+ if (test_havecoin) BOOST_CHECK(result_havecoin == !entry.IsSpent());
150+
151+ if (InsecureRandBits(4) == 0) {
140@@ -147,8 +141,22 @@ BOOST_AUTO_TEST_CASE(coins_cache_simulation_test)
141 {
142 uint256 txid = txids[InsecureRandRange(txids.size())]; // txid we're going to modify in this iteration.
143 Coin& coin = result[COutPoint(txid, 0)];
144+
145+ // Determine whether to test HaveCoin before or after Access* (or both). As these functions
146+ // can influence eachother's behaviour by pulling things into the cache, all combinations
This removes the possibility for GetCoin/HaveCoin/HaveCoinInCache to return
true while the respective coin is spent. By doing it across all calls, some
extra checks can be eliminated.
coins_tests is modified to call HaveCoin sometimes before and sometimes
after AccessCoin. A further change is needed because the semantics for
GetCoin slightly changed, causing a pruned entry in the parent cache to not
be pulled into the child in FetchCoin.
