scripted-diff: Make use of the improved handling of two consecutive right angle brackets in C++11 #10597

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:right-angle-brackets changing 50 files +103 −103
  1. practicalswift commented at 9:38 AM on June 15, 2017: contributor

    Improve code readability by removing the legacy handling of two consecutive right angle brackets that was required prior to C++11. Non-functional change.

    After this commit:

    $ git grep "> >" -- "*.cpp" "*.h" | grep -v '/leveldb/' | wc -l
    0
    
  2. practicalswift renamed this:
    scripted-diff: Make use of C++11:s improved handling of two consecutive right angle brackets
    scripted-diff: Make use of the improved handling of two consecutive right angle brackets in C++11
    on Jun 15, 2017
  3. practicalswift force-pushed on Jun 15, 2017
  4. fanquake added the label Refactoring on Jun 15, 2017
  5. scripted-diff: Make use of the improved handling of two consecutive right angle brackets in C++11
    Improve code readability by removing the legacy handling of two consecutive
    right angle brackets that was required prior to C++11. Non-functional change.
    
    After this commit:
    
    ```
    $ git grep "> >" -- "*.cpp" "*.h" | grep -v '/leveldb/' | wc -l
    0
    ```
    
    -BEGIN VERIFY SCRIPT-
    sed -i 's/> >/>>/g' src/*.cpp src/*.h src/compat/*.cpp src/policy/*.cpp src/qt/*.cpp src/qt/*.h src/qt/test/*.cpp src/rpc/*.cpp src/script/*.cpp src/script/*.h src/support/allocators/*.h src/test/*.cpp src/wallet/*.cpp src/wallet/*.h
    sed -i 's/> >/>>/g' src/keystore.h
    sed -i 's/std::vector< std::vector/std::vector<std::vector/g' src/qt/rpcconsole.cpp
    sed -i 's/std::set< std::set/std::set<std::set/g' src/wallet/wallet.cpp src/wallet/wallet.h
    sed -i 's/>\* >/>*>/g' src/wallet/wallet.cpp
    sed -i 's/std::map< CTxDestination/std::map<CTxDestination/g' src/wallet/wallet.cpp
    -END VERIFY SCRIPT-
    30726c3bcf
  6. practicalswift force-pushed on Jun 15, 2017
  7. ryanofsky commented at 1:06 PM on June 15, 2017: member

    Need to update src/.clang-format or it will keep introducing these:

    -Standard:        Cpp03
    +Standard:        Cpp11
    
  8. MarcoFalke commented at 1:48 PM on June 15, 2017: member

    According to the developer notes, Do not submit patches solely to modify the style of existing code. https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#developer-notes

    On Thu, Jun 15, 2017 at 3:07 PM, Russell Yanofsky notifications@github.com wrote:

    Need to update src/.clang-format https://github.com/bitcoin/bitcoin/blob/fa5137c11d2d4accd9bfc68b3498e7e16829c3ab/src/.clang-format#L50 or it will keep introducing these:

    -Standard: Cpp03+Standard: Cpp11

    — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/10597#issuecomment-308723958, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGmv0UYlXMGYI4ke4TgHkE_ZfPLBvDvks5sESyCgaJpZM4N693a .

  9. practicalswift commented at 2:03 PM on June 15, 2017: contributor

    OK, closing! :-)

  10. practicalswift closed this on Jun 15, 2017

  11. practicalswift deleted the branch on Apr 10, 2021
  12. DrahtBot locked this on Aug 18, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-16 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me