Remove the virtual specifier for functions with the override specifier #10701

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:virtual-override changing 2 files +8 −8

practicalswift commented at 11:08 AM on June 29, 2017: contributor

Remove the virtual specifier for functions with the override specifier.

override implies that the function is virtual (in addition - of course - to guaranteeing that the function is overriding a virtual function from a base class).
fanquake added the label Refactoring on Jun 29, 2017

Remove the virtual specifier for functions with the override specifier

`override` guarantees that the function is virtual (in addition
to that the function is overriding a virtual function from a base
class).

1bcd44223c

practicalswift force-pushed on Aug 9, 2017
laanwj commented at 10:22 AM on August 28, 2017: member

utACK https://github.com/bitcoin/bitcoin/pull/10701/commits/1bcd44223cdc1b584c0cd0863fe9653f540cf856
laanwj referenced this in commit a98af1cdd6 on Aug 28, 2017
TheBlueMatt commented at 7:42 PM on September 4, 2017: member

utACK
sipa commented at 7:44 PM on September 4, 2017: member

utACK 1bcd44223cdc1b584c0cd0863fe9653f540cf856
MarcoFalke merged this on Sep 5, 2017
MarcoFalke closed this on Sep 5, 2017
MarcoFalke referenced this in commit 50fae68d41 on Sep 5, 2017
PastaPastaPasta referenced this in commit 48a55ddfd2 on Sep 19, 2019
PastaPastaPasta referenced this in commit 5605ac5bbb on Sep 19, 2019
PastaPastaPasta referenced this in commit 184c6b675f on Sep 23, 2019
PastaPastaPasta referenced this in commit eb92378b7d on Sep 24, 2019
PastaPastaPasta referenced this in commit 067e7f4092 on Nov 19, 2019
PastaPastaPasta referenced this in commit 8cade240d2 on Nov 21, 2019
PastaPastaPasta referenced this in commit 79234b237b on Dec 9, 2019
PastaPastaPasta referenced this in commit b8927447e0 on Jan 1, 2020
PastaPastaPasta referenced this in commit 686a00ff58 on Jan 2, 2020
PastaPastaPasta referenced this in commit c30597daed on Jan 2, 2020
ckti referenced this in commit df37c66bf9 on Mar 28, 2021
practicalswift deleted the branch on Apr 10, 2021
gades referenced this in commit c680659f3f on Jun 30, 2021
gades referenced this in commit 20e58bc33a on Jan 29, 2022
DrahtBot locked this on Aug 18, 2022

Contributors

Labels