Building Environment: Set ARFLAGS to cr #10766

pull ReneNyffenegger wants to merge 1 commits into bitcoin:master from ReneNyffenegger:ARFLAGS changing 1 files +7 −0

ReneNyffenegger commented at 3:00 PM on July 7, 2017: contributor
Override the default of ARFLAGS of cru to cr.

When building, ar produces a warning for each archive, for example
```
  AR       libbitcoin_server.a
/usr/bin/ar: `u' modifier ignored since `D' is the default (see `U')
```
Since u is the default anyway, it cannot hurt to remove it.
fanquake added the label Build system on Jul 7, 2017
practicalswift commented at 8:08 PM on July 7, 2017: contributor

Concept ACK

Nit: I don't think that u is the default - IIRC it is just that u optimization has no effect when running in deterministic mode (D), which is now the default.
theuni commented at 11:30 PM on July 7, 2017: member
Concept ACK. Though, please don't hard-code it to "cr" in case the change causes trouble for some toolchain. Let's use AC_ARG_VAR instead, so that it may be overridden if necessary:
```
AC_ARG_VAR(ARFLAGS, [flags passed to the archiver])
if test "x${ARFLAGS+set}" != "xset"; then
  ARFLAGS="cr"
fi
```
ReneNyffenegger commented at 12:47 PM on July 10, 2017: contributor

I agree / have created a hopefully improved pull request: 10782
theuni commented at 7:02 PM on July 10, 2017: member

Thanks. utACK after squash.
jonasschnelli commented at 7:34 AM on July 13, 2017: contributor

utACK bb4bb93216c47276b16e89bd0ba2632c801caddf @ReneNyffenegger: can you squash the commits? Your first commit (bb4bb93216c47276b16e89bd0ba2632c801caddf) has "unrecoggnized author".
ReneNyffenegger force-pushed on Jul 13, 2017
ReneNyffenegger commented at 12:15 PM on July 13, 2017: contributor

I've squashed to commits / Hope the user is now recognized.

in configure.ac:24 in 245ceb6f8c outdated

  18 | @@ -19,6 +19,12 @@ BITCOIN_GUI_NAME=bitcoin-qt
  19 |  BITCOIN_CLI_NAME=bitcoin-cli
  20 |  BITCOIN_TX_NAME=bitcoin-tx
  21 |  
  22 | +dnl Unless the user specified ARFLAGS, force it to be cr
  23 | +AC_ARG_VAR(ARFLAGS, [Flags for the archiver, defaults to <cr> if not set])
  24 | +if test "x${ARFLAGS}" != "xset"; then

TheBlueMatt commented at 8:24 PM on July 14, 2017:

Do you need the x${ARFLAGS+set} syntax that we use elsewhere?

in configure.ac:25 in 245ceb6f8c outdated

  18 | @@ -19,6 +19,12 @@ BITCOIN_GUI_NAME=bitcoin-qt
  19 |  BITCOIN_CLI_NAME=bitcoin-cli
  20 |  BITCOIN_TX_NAME=bitcoin-tx
  21 |  
  22 | +dnl Unless the user specified ARFLAGS, force it to be cr
  23 | +AC_ARG_VAR(ARFLAGS, [Flags for the archiver, defaults to <cr> if not set])
  24 | +if test "x${ARFLAGS}" != "xset"; then
  25 | +  ARFLAGS="cr"

TheBlueMatt commented at 8:25 PM on July 14, 2017:

Maybe add D to the default here, so that we're consistent even on platforms with a strange ar build?

TheBlueMatt commented at 8:25 PM on July 14, 2017: member

Concept ACK, though I tested and overriding doesnt work.
ReneNyffenegger force-pushed on Jul 15, 2017
ReneNyffenegger commented at 2:43 PM on July 15, 2017: contributor

overriding didn't work.... because I goofed up when I manually tried to merge two branches: I had if test "x${ARFLAGS}"... instead of if test "x${ARFLAGS+set}"...

With the fix, I've also added the D flag
ReneNyffenegger commented at 4:51 PM on July 15, 2017: contributor

Apparently, the D flag is not liked in the Darwin environment.
TheBlueMatt commented at 4:59 PM on July 15, 2017: member

Heh, ok, just leave it as cr I suppose.
ReneNyffenegger force-pushed on Jul 15, 2017
ReneNyffenegger force-pushed on Jul 15, 2017
ReneNyffenegger commented at 7:53 PM on July 15, 2017: contributor

I have removed the D flag again. Now, I have also commit 816aa59. I don't know why this is, if I should remove it, and how I could remove it.
practicalswift commented at 8:17 PM on July 15, 2017: contributor
@ReneNyffenegger Please do:
```
git rebase -i HEAD~2
# remove the line with "Fix multi_rpc test …"
git push -f
```
ReneNyffenegger force-pushed on Jul 15, 2017
ReneNyffenegger commented at 8:21 PM on July 15, 2017: contributor

done rebase.
practicalswift commented at 8:23 PM on July 15, 2017: contributor

utACK 517bfb174a5affc426d8eeb008cb42c49b8f59a9

Use AC_ARG_VAR to set ARFLAGS.

The user can set ARFLAGS in the ./configure step with
  ./configure ARFLAGS=...
If he chooses not to do so, ARFLAGS will be set to cr.

912da1dcc8

ReneNyffenegger force-pushed on Jul 15, 2017
TheBlueMatt commented at 6:36 PM on July 16, 2017: member

ACK 912da1dcc8e52228582f36b0010b498ebc76754b. We'll need to do something about similar warnings in leveldb and secp256k1, but those will need to be submitted separately upstream.
sipa commented at 6:51 PM on July 16, 2017: member

utACK 912da1dcc8e52228582f36b0010b498ebc76754b
practicalswift commented at 6:54 PM on July 16, 2017: contributor

utACK 912da1d
sipa merged this on Jul 16, 2017
sipa closed this on Jul 16, 2017
sipa referenced this in commit b4d03be3ca on Jul 16, 2017
zkbot referenced this in commit 75604363cc on Dec 1, 2017
zkbot referenced this in commit 6aef4033a7 on Dec 1, 2017
zkbot referenced this in commit 83af270002 on Dec 15, 2017
kotodev referenced this in commit c8a979fc92 on Jan 25, 2018
renium9 referenced this in commit 23640da445 on Feb 6, 2018
PastaPastaPasta referenced this in commit 5d1e068285 on Jul 6, 2019
PastaPastaPasta referenced this in commit 6815ce7df8 on Jul 8, 2019
PastaPastaPasta referenced this in commit 832292c4c2 on Jul 9, 2019
PastaPastaPasta referenced this in commit 75c0020663 on Jul 11, 2019
PastaPastaPasta referenced this in commit d4b6001343 on Jul 13, 2019
PastaPastaPasta referenced this in commit 3885f5e770 on Jul 13, 2019
PastaPastaPasta referenced this in commit 9243b65ccc on Jul 17, 2019
PastaPastaPasta referenced this in commit 0eebff991e on Jul 17, 2019
PastaPastaPasta referenced this in commit d7057d429e on Jul 18, 2019
barrystyle referenced this in commit 95ef2e4a0d on Jan 22, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#10782 Use AC_ARG_VAR to set ARFLAGS