The compiler apparently is unable to detect that nStart is initialized and issues a warning because -Wmaybe-uniniatiialized is enalbed.
The #pragma ... and #pragma ... pop prevent the warning for the line in question.
Build System: Prevent warning about "maybe uninitialized variable" nStart in init.cpp #10768
pull ReneNyffenegger wants to merge 3 commits into bitcoin:master from ReneNyffenegger:init-nStart changing 1 files +2 −0-
ReneNyffenegger commented at 3:33 PM on July 7, 2017: contributor
-
Change ARFLAGS to cr to prevent warnings 'ar: u modifier ignored since D is the default ...' bb4bb93216
-
Prevent warning: ‘nStart’ may be used uninitialized in this function 234452654c
-
Revert changes on configure.ac d8b84eaef0
-
-
TheBlueMatt commented at 6:28 PM on July 7, 2017: member
Prefer #10714 - GCC is technically correct here, its a race to hit fShutdown before the print, no reason to silence it, we should fix our bug.
- jonasschnelli added the label Refactoring on Jul 7, 2017
-
ReneNyffenegger commented at 12:07 PM on July 13, 2017: contributor
This PR can be closed as #10714 has solved the problem this PR tried to address.
-
jtimon commented at 8:35 PM on July 13, 2017: contributor
It doesn't look like #10714 solved the warning? after #10714 don't we just need to initialize nStart to 0 when it's declared or something?Also, @ReneNyffenegger you can close your own PRs yourself if you want.
- ReneNyffenegger closed this on Jul 14, 2017
-
ReneNyffenegger commented at 4:12 AM on July 14, 2017: contributor
I didn't know I could close my pull requests. Doing it now.
- ReneNyffenegger deleted the branch on Jul 14, 2017
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels