[tests] Avoid redundant assignments. Remove unused variables #10777

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:test-vars changing 2 files +4 −10

practicalswift commented at 9:44 PM on July 8, 2017: contributor
- Remove unused variables.
- Avoid redundant assignments.
fanquake added the label Tests on Jul 8, 2017
[tests] Avoid redundant assignments. Remove unused variables. 49eb0916da
in src/test/sighash_tests.cpp:131 in ebeed8abb6 outdated
```
 131 | -    nRandomTests = 500;
 132 | +    int nRandomTests = 500;
 133 | +    #else
 134 | +    int nRandomTests = 50000;
 135 |      #endif
 136 |      for (int i=0; i<nRandomTests; i++) {
```
paveljanik commented at 10:55 AM on July 9, 2017:

nRandomTests is undeclared in case of !defined(PRINT_SIGHASH_JSON). There are too many #if defined(PRINT_SIGHASH_JSON) anyway...

practicalswift commented at 11:07 AM on July 9, 2017:

@paveljanik Merged the two #if defined(PRINT_SIGHASH_JSON):s. Looks better?

paveljanik commented at 1:01 PM on July 9, 2017:

BTW - PRINT_SIGHASH_JSON is never defined in our tree.

practicalswift commented at 5:51 PM on July 9, 2017:

@paveljanik The ifdef was added in 232aa9e034d4d48f4d16dfdc6bc0d56c9274cfd3 by @maraoz to control if data/sighash.json test data should be written. Is it no longer needed?
practicalswift force-pushed on Jul 9, 2017
TheBlueMatt commented at 12:16 AM on July 10, 2017: member

utACK 49eb0916da3f07250393111b6bbff080b3d8edd6
paveljanik commented at 8:46 PM on July 14, 2017: contributor

utACK 49eb091

But I still wonder who and where defines PRINT_SIGHASH_JSON .
practicalswift renamed this:
~~[tests] Avoid redundant assignments. Remove unused variables.~~
[tests] Avoid redundant assignments. Remove unused variables
on Aug 29, 2017
MarcoFalke merged this on Aug 30, 2017
MarcoFalke closed this on Aug 30, 2017
MarcoFalke referenced this in commit d81dccf191 on Aug 30, 2017
jasonbcox referenced this in commit 5e110a02f6 on Jul 25, 2019
jonspock referenced this in commit c67cb7bc8d on Sep 5, 2019
jonspock referenced this in commit f99bd78e3f on Sep 6, 2019
proteanx referenced this in commit 2682972f0c on Sep 6, 2019
PastaPastaPasta referenced this in commit 8a69a77a05 on Sep 19, 2019
PastaPastaPasta referenced this in commit 847c526a22 on Sep 23, 2019
PastaPastaPasta referenced this in commit b2f9ded58d on Sep 24, 2019
PastaPastaPasta referenced this in commit 69fa650080 on Nov 19, 2019
PastaPastaPasta referenced this in commit 8df95bd41a on Nov 21, 2019
PastaPastaPasta referenced this in commit eaf403250c on Dec 9, 2019
PastaPastaPasta referenced this in commit ed09b38d95 on Jan 1, 2020
PastaPastaPasta referenced this in commit 2640c19a26 on Jan 2, 2020
PastaPastaPasta referenced this in commit 4b998f0fad on Jan 2, 2020
PastaPastaPasta referenced this in commit fff2cea0b9 on Jan 2, 2020
PastaPastaPasta referenced this in commit d9cfb69f62 on Jan 2, 2020
PastaPastaPasta referenced this in commit 24fef644fb on Jan 2, 2020
PastaPastaPasta referenced this in commit ce2eeaef5f on Jan 3, 2020
ckti referenced this in commit c3b3425a69 on Mar 28, 2021
practicalswift deleted the branch on Apr 10, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels