Explicitly search for bdb5.3. #10803

pull pstratem wants to merge 1 commits into bitcoin:master from pstratem:2017-07-02-bdb5.3 changing 1 files +1 −1

pstratem commented at 2:01 PM on July 12, 2017: contributor

Some systems do not symlink the major version to the minor version.

Explicitly search for bdb5.3.

Some systems do not symlink the major version to the minor version.

1cc251f50f

jonasschnelli commented at 2:58 PM on July 12, 2017: contributor

Should not hurt. utACK 1cc251f50fb2f9cffa762b28e5d8685af4273663
gmaxwell commented at 7:57 PM on July 12, 2017: contributor

utACK. Should other versions be added too?
pstratem commented at 8:04 PM on July 12, 2017: contributor

The only things I've seen are 4.8 5.3 and versions under 4.8 which we probably dont want to every use.
gmaxwell commented at 6:12 AM on July 13, 2017: contributor

I believe 6 is a thing.
pstratem commented at 2:53 AM on July 14, 2017: contributor

@gmaxwell i've never actually seen 6.x on any system, but i guess no problem searching for it
luke-jr commented at 2:59 AM on July 14, 2017: member

But BDB 6 is AGPL, which Bitcoin Core is not compliant with (the node would need to share its own source code to peers somehow).
laanwj added the label Build system on Jul 14, 2017
laanwj commented at 7:28 AM on July 14, 2017: member

I've never seen 6.x on a system either. Looks like the license change caused to fail adoption.

utACK https://github.com/bitcoin/bitcoin/pull/10803/commits/1cc251f50fb2f9cffa762b28e5d8685af4273663

Edit: at least for ubuntu, bdb 6.0 was never packaged: https://packages.ubuntu.com/search?keywords=libdb&searchon=names&suite=yakkety&section=all . So we'd have no idea in what directory to look either.
TheBlueMatt commented at 8:55 PM on July 14, 2017: member

utACK 1cc251f50fb2f9cffa762b28e5d8685af4273663
sipa commented at 12:17 AM on July 15, 2017: member

utACK 1cc251f50fb2f9cffa762b28e5d8685af4273663
laanwj merged this on Jul 17, 2017
laanwj closed this on Jul 17, 2017
laanwj referenced this in commit 91edda8f3c on Jul 17, 2017
PastaPastaPasta referenced this in commit 68f6e24002 on Jul 6, 2019
PastaPastaPasta referenced this in commit df4e27141a on Jul 8, 2019
PastaPastaPasta referenced this in commit 1e51c2bc15 on Jul 9, 2019
PastaPastaPasta referenced this in commit b7b05be452 on Jul 11, 2019
PastaPastaPasta referenced this in commit 28f21bb5a1 on Jul 13, 2019
PastaPastaPasta referenced this in commit 44fcd73683 on Jul 13, 2019
PastaPastaPasta referenced this in commit ab5a244f9a on Jul 17, 2019
PastaPastaPasta referenced this in commit e747e803db on Jul 23, 2019
PastaPastaPasta referenced this in commit 9ad533089d on Jul 24, 2019
barrystyle referenced this in commit e6c93f78e8 on Jan 22, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels