--with-boost=no requires boost #10826

issue janstary opened this issue on July 14, 2017

janstary commented at 4:03 PM on July 14, 2017: none
This is 0.14.2 being built on OpenBSD 6.1-current. If I don't mention boost at all in ./configure, it gets detected and compiled in. Strangely, ./configure --with-boost=no fails and complains boost was not found.
```
 env AUTOCONF_VERSION=2.69  AUTOMAKE_VERSION=1.15 sh autogen.sh
./configure --prefix=$HOME --mandir=$HOME/man --disable-tests --disable-gui-tests --disable-wallet --with-gui=no --with-boost=no CC=egcc CXX=eg++

...
checking whether the Boost::System library is available... yes
configure: error: Could not find a version of the boost_system library!
```
Even more confusingly, it reports Boost::System as available, only to complain it could not find it a line later.
TheBlueMatt commented at 4:07 PM on July 14, 2017: member
We don't support building without boost, so I'd say this may be the expected outcome (you specified we should build without boost).

On July 14, 2017 12:03:51 PM EDT, janstary notifications@github.com wrote:
This is 0.14.2 being built on OpenBSD 6.1-current. If I don't mention boost at all in ./configure, it gets detected and compiled in. Strangely, ./configure --with-boost=no fails and complains boost was not found.

env AUTOCONF_VERSION=2.69 AUTOMAKE_VERSION=1.15 sh autogen.sh ./configure --prefix=$HOME --mandir=$HOME/man --disable-tests --disable-gui-tests --disable-wallet --with-gui=no --with-boost=no CC=egcc CXX=eg++ ... checking whether the Boost::System library is available... yes configure: error: Could not find a version of the boost_system library!

Even more confusingly, it reports Boost::System as available, only to complain it could not find it a line later.
janstary commented at 4:20 PM on July 14, 2017: none

If building without boost is not supported, then --with-boost=no shouldn't even exist as a documented option in ./configure
theuni commented at 4:38 PM on July 14, 2017: member

boost isn't needed for building libbitcoinconsensus. The issue here is that we don't fail if --without-boost is specified but something needs it.

theuni commented at 4:51 PM on July 14, 2017: member

potential fix, though I'm not sure how to make the error any less cryptic. I'd rather not copy/paste all of the things that do require boost.

diff --git a/configure.ac b/configure.ac
index a90063d..02379df 100644
--- a/configure.ac
+++ b/configure.ac
@@ -691,6 +691,11 @@ define(MINIMUM_REQUIRED_BOOST, 1.47.0)
 
 dnl Check for boost libs
 AX_BOOST_BASE([MINIMUM_REQUIRED_BOOST])
+
+if test x$want_boost = xno; then
+    AC_MSG_ERROR([[only libbitcoinconsensus can be built without boost]])
+fi
+
 AX_BOOST_SYSTEM
 AX_BOOST_FILESYSTEM
 AX_BOOST_PROGRAM_OPTIONS

janstary commented at 5:15 PM on July 14, 2017: none

It would be IMHO less confusing to just require boost in any case.
janstary renamed this:
~~--with=boost=no requires boost~~
--with-boost=no requires boost
on Jul 14, 2017
fanquake added the label Build system on Jul 17, 2017
laanwj commented at 9:23 AM on August 24, 2017: member

There might be other parts that don't require boost in the near future, so I don't like requiring it wholesale.

Agree it should be an error if --with-boost=no is provided but the user wants to build parts that require boost.
laanwj closed this on Dec 19, 2017
laanwj referenced this in commit 483bb67253 on Dec 19, 2017
PastaPastaPasta referenced this in commit 498cd3cb5d on Jan 17, 2020
PastaPastaPasta referenced this in commit b06d49b29a on Jan 22, 2020
PastaPastaPasta referenced this in commit 5a648a8879 on Jan 22, 2020
PastaPastaPasta referenced this in commit 763330e280 on Jan 29, 2020
PastaPastaPasta referenced this in commit 5ba3798e25 on Jan 29, 2020
PastaPastaPasta referenced this in commit 84d5f3b008 on Jan 29, 2020
PastaPastaPasta referenced this in commit ec35169d92 on Jan 31, 2020
ckti referenced this in commit ff1dad55e1 on Mar 28, 2021
gades referenced this in commit 32e02dda7e on Jun 26, 2021
DrahtBot locked this on Sep 8, 2021
gades referenced this in commit d4b81d8abc on Mar 16, 2022

Contributors

Labels

Linked (view graph)

#11806 [Build]: Modify error if boost lib is not found #11936 [build] Warn that only libconsensus can be built without Boost