[Build]: Modify error if boost lib is not found #11806

pull Varunram wants to merge 1 commits into bitcoin:master from Varunram:boost changing 1 files +3 −0

Varunram commented at 4:16 AM on December 1, 2017: contributor
Related Issue: #10826

The fix in this PR was suggested by theuni, but since it wasn't implemented yet, thought I'd put in a PR for it. We do fail now if --with-boost=no is specified but the error message is as follows:
```
[...]
checking whether to build Bitcoin Core GUI... yes (Qt5)
configure: error: only libbitcoinconsensus can be built without boost
```
Removes the ambiguous checking whether the Boost::System library is available... yes message that comes now.
Scripts: Modify error if boost lib is not found ce444779ec
fanquake added the label Build system on Dec 1, 2017
fanquake renamed this:
~~[Scripts]: Modify error if boost lib is not found~~
[Build]: Modify error if boost lib is not found
on Dec 1, 2017
fanquake commented at 5:21 AM on December 1, 2017: member
Quickly tested ACK ce44477

./configure --with-utils=no --disable-bench --disable-gui-tests --disable-tests --with-daemon=no --without-gui --disable-wallet --with-boost=no builds libconsensus.

./configure --with-boost=no with or without any other options always seems to fail with:
```
checking whether to build Bitcoin Core GUI... yes (Qt5)
configure: error: only libbitcoinconsensus can be built without boost
```
Can you update the commit message to something like "[build] Warn that only libconsensus can be built without boost"
in configure.ac:764 in ce444779ec
```
 760 | @@ -761,6 +761,9 @@ define(MINIMUM_REQUIRED_BOOST, 1.47.0)
 761 |  
 762 |  dnl Check for boost libs
 763 |  AX_BOOST_BASE([MINIMUM_REQUIRED_BOOST])
 764 | +if test x$want_boost = xno; then
```
laanwj commented at 12:09 PM on December 1, 2017:

Shouldn't this check be right after if test x$use_boost = xyes; then, not after AX_BOOST_BASE? Otherwise it will still do a boost version check even though no boost was requested.

Varunram commented at 2:50 PM on December 1, 2017:

That's what I tried at first too, but it seems to spawn checking whether the Boost::System library is available... yes Any ideas why?

laanwj commented at 3:17 PM on December 1, 2017:

No, no idea, that's kind of where my autotools knowledge stops. Maybe @theuni can help.

theuni commented at 9:00 PM on December 6, 2017:

Annoyingly, it's the AX_BOOST_BASE macro that does the --with-boost handling (along with the actual checks), and sets "want_boost" so this looks ok to me. Thankfully, the tests won't run if want_boost is false, so "--without-boost" should work as expected here.
Varunram commented at 2:51 PM on December 1, 2017: contributor

fanquake: will do
theuni commented at 9:02 PM on December 6, 2017: member

utACK. Looks good to me after addressing @fanquake's comment
fanquake commented at 6:40 AM on December 18, 2017: member

Replaced by #11936.
fanquake closed this on Dec 18, 2017
Varunram commented at 7:25 AM on December 18, 2017: contributor

Sorry I didn't address the comment, I thought it was pending some discussion. Thanks fanquake for the new PR.
laanwj referenced this in commit 483bb67253 on Dec 19, 2017
virtload referenced this in commit 14db9e177a on Apr 4, 2018
PastaPastaPasta referenced this in commit 498cd3cb5d on Jan 17, 2020
PastaPastaPasta referenced this in commit b06d49b29a on Jan 22, 2020
PastaPastaPasta referenced this in commit 5a648a8879 on Jan 22, 2020
PastaPastaPasta referenced this in commit 763330e280 on Jan 29, 2020
PastaPastaPasta referenced this in commit 5ba3798e25 on Jan 29, 2020
PastaPastaPasta referenced this in commit 84d5f3b008 on Jan 29, 2020
PastaPastaPasta referenced this in commit ec35169d92 on Jan 31, 2020
ckti referenced this in commit ff1dad55e1 on Mar 28, 2021
gades referenced this in commit 32e02dda7e on Jun 26, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#10826 --with-boost=no requires boost #11936 [build] Warn that only libconsensus can be built without Boost