Alternative to #10818, alternative solution to #10815.
After this change: All the AppInit steps before and inclusive AppInitLockDataDirectory must not have Shutdown() called in case of failure. Only when AppInitMain fails, Shutdown should be called.
Changes the GUI and bitcoind code to consistently do this.
1185 | // will at most make us exit without printing a message to console.
1186 | if (!LockDataDirectory(false)) {
1187 | // Detailed error printed inside LockDataDirectory
1188 | return false;
1189 | }
1190 | + return true;
Why not just return LockDataDirectory(false); without the if statement? If statement seems unnecessary
The comments seem useful.
Yeah I mean you could keep the comments and just remove the if statement, if(something) then true else false make things a bit less clear IMO. But this is a simple case, not a big deal either way
utACK although you could refactor braces onto same line as if-statements in baseInitialize (or is it better not to mix refactor with changes?)
utACK although you could refactor braces onto same line as if-statements in baseInitialize (or is it better not to mix refactor with changes?)
Could do that, but I'd prefer to not increase the scope of this to code style enforcement (of existing code). I just want to fix this issue.
utACK d4c027dd4acb77d2c5ee38ae883110abc3796d52, thanks. (modulo not sure I know enough about the Qt init process to say this is definitely right).
tested ACK
Alternative to #10818, alternative solution to #10815.
After this change: All the AppInit steps before and inclusive
AppInitLockDataDirectory must not have Shutdown() called in case of
failure. Only when AppInitMain fails, Shutdown should be called.
Changes the GUI and bitcoind code to consistently do this.
Squashed ceec6cb 26fa3fc d4c027d → dba485d65168794d8be39bd5e8de8777e7085434.