Alternative to #10838
This PR disables getinfo by default in v0.15.0. getinfo will return a string informing the user that getinfo is deprecated, but can be enabled in v0.15.0 by running with -enablegetinfo. v0.15.1 will remove getinfo entirely.
Should address @achow101’s objection to #10838 by giving clients a final warning before removing the RPC in v0.15.1.
Draws a final line in the sand. getinfo will be gone in v0.15.1
@TheBlueMatt
utACK 6c9f2c1c5326a158bffff8b4ca9822f6fdb81ca9
I also prefer that getinfo be actually disabled in 0.16.0 not 0.15.1.
getinfo in a minor release. I wouldn’t explicitly name a version number in the source code either, just say it will be removed in a next release.
Yes, best practice would be to not make a breaking API change in a point release. Changed getinfo End Of Life to v0.16 as suggested.
@sipa - I prefer to have a hard EOL version. Users will ignore deprecation warnings if there is no hard date/release. Such is the way of the world. We can always slip v0.16 if there’s a strongly compelling reason to retain getinfo.
Any feedback on the warning text?
0return "getinfo is deprecated and will be fully removed in v0.16. To use getinfo in v0.15, restart bitcoind with -enablegetinfo.\n"
1 "Projects should transition to using getblockchaininfo, getnetworkinfo and getwalletinfo before upgrading to v0.16";
87@@ -88,7 +88,6 @@ def run_test(self):
88 self.nodes[0].generate(VB_PERIOD - VB_THRESHOLD + 1)
89 # Check that we're not getting any versionbit-related errors in
90 # get*info()
91- assert(not VB_PATTERN.match(self.nodes[0].getinfo()["errors"]))
errors moved to getblockchaininfo
"nag": "This RPC will be deprecated." to the output with the message, instead of requiring a command-line argument. This would have less last-minute API impact (could still do this for 0.16).