[rpc] Give users one final warning before removing getinfo #10841

1. 
   jnewbery commented at 5:28 am on July 16, 2017: member

   Alternative to #10838

   This PR disables getinfo by default in v0.15.0. getinfo will return a string informing the user that getinfo is deprecated, but can be enabled in v0.15.0 by running with -enablegetinfo. v0.15.1 will remove getinfo entirely.

   Should address @achow101’s objection to #10838 by giving clients a final warning before removing the RPC in v0.15.1.

   Draws a final line in the sand. getinfo will be gone in v0.15.1 @TheBlueMatt

2. jnewbery renamed this:
   [rpc] Give users one final warning before depracating getinfo
   [rpc] Give users one final warning before removing getinfo
   on Jul 16, 2017
3. fanquake added this to the milestone 0.15.0 on Jul 16, 2017
4. fanquake added the label RPC/REST/ZMQ on Jul 16, 2017
5. 
   TheBlueMatt commented at 4:50 pm on July 16, 2017: member

   utACK 6c9f2c1c5326a158bffff8b4ca9822f6fdb81ca9, though I’d prefer to say that we’ll disable it in 16, not 15.1.
6. 
   achow101 commented at 6:11 pm on July 16, 2017: member

   utACK 6c9f2c1c5326a158bffff8b4ca9822f6fdb81ca9

   I also prefer that getinfo be actually disabled in 0.16.0 not 0.15.1.

7. 
   sipa commented at 7:04 pm on July 16, 2017: member

   Agree that we shouldn’t remove getinfo in a minor release. I wouldn’t explicitly name a version number in the source code either, just say it will be removed in a next release.
8. [rpc] Give users one final warning before depracating getinfo dbcbb86b2f
9. jnewbery force-pushed on Jul 16, 2017
10. 
    jnewbery commented at 11:19 pm on July 16, 2017: member

    Yes, best practice would be to not make a breaking API change in a point release. Changed getinfo End Of Life to v0.16 as suggested. @sipa - I prefer to have a hard EOL version. Users will ignore deprecation warnings if there is no hard date/release. Such is the way of the world. We can always slip v0.16 if there’s a strongly compelling reason to retain getinfo.

    Any feedback on the warning text?

    0return "getinfo is deprecated and will be fully removed in v0.16. To use getinfo in v0.15, restart bitcoind with -enablegetinfo.\n"
    1    "Projects should transition to using getblockchaininfo, getnetworkinfo and getwalletinfo before upgrading to v0.16";
    

11. 
    TheBlueMatt commented at 11:27 pm on July 16, 2017: member

    utACK dbcbb86b2f5af807c9520966f30b24a44eb378b4
12. in test/functional/p2p-versionbits-warning.py:91 in dbcbb86b2f

    87@@ -88,7 +88,6 @@ def run_test(self):
    88         self.nodes[0].generate(VB_PERIOD - VB_THRESHOLD + 1)
    89         # Check that we're not getting any versionbit-related errors in
    90         # get*info()
    91-        assert(not VB_PATTERN.match(self.nodes[0].getinfo()["errors"]))
    

    ---

    ---

    

    laanwj commented at 6:10 am on July 17, 2017:

    errors moved to getblockchaininfo
13. 
    laanwj commented at 6:12 am on July 17, 2017: member

    I think it’s too late in the release window to be disabling this. We’d probably wanted to have merged #8843 too in that case.
14. 
    laanwj commented at 7:34 am on July 17, 2017: member

    An alternative that was proposed on IRC by @gmaxwell was to add a "nag": "This RPC will be deprecated." to the output with the message, instead of requiring a command-line argument. This would have less last-minute API impact (could still do this for 0.16).
15. jnewbery closed this on Jul 17, 2017

    ---

16. laanwj referenced this in commit d445a2c2ea on Jul 19, 2017
17. MarcoFalke referenced this in commit ef8340d25f on Sep 27, 2017
18. PastaPastaPasta referenced this in commit 7dc442fe98 on Jul 17, 2019
19. PastaPastaPasta referenced this in commit e29dba1356 on Jul 17, 2019
20. PastaPastaPasta referenced this in commit 394b211ba8 on Jul 23, 2019
21. PastaPastaPasta referenced this in commit b535dfbc41 on Jul 24, 2019
22. PastaPastaPasta referenced this in commit ce4a9b49ff on Dec 22, 2019
23. PastaPastaPasta referenced this in commit 817e8ecdf6 on Jan 2, 2020
24. PastaPastaPasta referenced this in commit 63390920d5 on Jan 4, 2020
25. PastaPastaPasta referenced this in commit 4d597601ba on Jan 12, 2020
26. PastaPastaPasta referenced this in commit 5eee9c3946 on Jan 12, 2020
27. PastaPastaPasta referenced this in commit 58303cd55e on Jan 12, 2020
28. PastaPastaPasta referenced this in commit 56780e9e43 on Jan 12, 2020
29. PastaPastaPasta referenced this in commit 4af8db6d33 on Jan 12, 2020
30. barrystyle referenced this in commit 2f01e0bf42 on Jan 22, 2020
31. ckti referenced this in commit 78eb635f66 on Mar 28, 2021
32. gades referenced this in commit 12199bee20 on Jun 26, 2021
33. DrahtBot locked this on Sep 8, 2021

Contributors
jnewbery TheBlueMatt achow101 sipa laanwj

Labels
RPC/REST/ZMQ

Milestone
0.15.0