Fix incorrect Doxygen tag (@ince → @since). Doxygen parameter name matching. #10842

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:doxygen-since changing 4 files +6 −6

practicalswift commented at 10:22 AM on July 16, 2017: contributor
Doxygen fixes:
- Fix incorrect Doxygen tag (@ince → @since).
- Make Doxygen parameter names match actual parameter names.
fanquake added the label Docs and Output on Jul 16, 2017
fanquake commented at 10:24 AM on July 16, 2017: member

trivial ACK 8a2e5b1
practicalswift renamed this:
~~Fix incorrect Doxygen tag (@ince → @since)~~
Fix incorrect Doxygen tag (@ince → @since). Doxygen parameter name matching.
on Jul 16, 2017
practicalswift commented at 10:34 AM on July 16, 2017: contributor

@fanquake Thanks for the quick review. I added another commit to this PR (be9682d). Would you mind re-reviewing? :-)

in src/wallet/rpcwallet.h:19 in be9682dfb8 outdated

  15 | @@ -16,7 +16,7 @@ void RegisterWalletRPCCommands(CRPCTable &t);
  16 |   * @param[in] request JSONRPCRequest that wishes to access a wallet
  17 |   * @return NULL if no wallet should be used, or a pointer to the CWallet
  18 |   */
  19 | -CWallet *GetWalletForJSONRPCRequest(const JSONRPCRequest&);
  20 | +CWallet *GetWalletForJSONRPCRequest(const JSONRPCRequest& request);

meshcollider commented at 11:45 AM on July 16, 2017:

Why did you change this one and not the ones below it?

meshcollider commented at 11:46 AM on July 16, 2017:

Oh don't worry you're just focusing on doxygen, sorry missed that

practicalswift commented at 11:47 AM on July 16, 2017:

They don't have any Doxygen documentation to match :-)

MarcoFalke commented at 7:11 PM on July 16, 2017: member

Please squash when this is ready for merge.

On Sun, Jul 16, 2017 at 12:24 PM, fanquake notifications@github.com wrote:

trivial ACK 8a2e5b1 https://github.com/bitcoin/bitcoin/commit/8a2e5b1b2ee43142eea5949356754ab586de64c8

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/10842#issuecomment-315599837, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGmv1SEZLXxV9xK8bWqVfLoKQ0AgZ8Eks5sOeT2gaJpZM4OZQc- .
Fix incorrect Doxygen tag (@ince → @since). Make Doxygen parameter names match actual parameter names. 2c2e90d1d4
practicalswift force-pushed on Jul 16, 2017
practicalswift commented at 7:22 PM on July 16, 2017: contributor

@MarcoFalke Squashed! :-)
MarcoFalke commented at 9:43 PM on July 16, 2017: member

utACK 2c2e90d1d4768a7842b2fa840496cea567a8e995
MarcoFalke merged this on Jul 16, 2017
MarcoFalke closed this on Jul 16, 2017
MarcoFalke referenced this in commit 3895e25a77 on Jul 16, 2017
PastaPastaPasta referenced this in commit bb40a370b3 on Jul 6, 2019
PastaPastaPasta referenced this in commit 2576285270 on Jul 8, 2019
PastaPastaPasta referenced this in commit d34fd6a965 on Jul 9, 2019
PastaPastaPasta referenced this in commit 23a0405ad4 on Jul 11, 2019
PastaPastaPasta referenced this in commit dc5f432d9c on Jul 13, 2019
PastaPastaPasta referenced this in commit 76932b991d on Jul 13, 2019
PastaPastaPasta referenced this in commit 5a02464b7c on Jul 17, 2019
PastaPastaPasta referenced this in commit 93f422695c on Jul 23, 2019
PastaPastaPasta referenced this in commit fc94fac752 on Jul 24, 2019
barrystyle referenced this in commit bb4679b347 on Jan 22, 2020
jasonbcox referenced this in commit 73474a4ace on Oct 7, 2020
practicalswift deleted the branch on Apr 10, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels