Enable devirtualization opportunities by using the final specifier (C++11) #10847

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:devirtualization changing 2 files +2 −2

practicalswift commented at 9:23 PM on July 16, 2017: contributor
Enable devirtualization opportunities by using the final specifier (C++11).
- Declaring CCoinsViewErrorCatcher final enables devirtualization of two calls
- Declaring CReserveKey final enables devirtualization of one call
sipa commented at 9:34 PM on July 16, 2017: member

See also #10809

Enable devirtualization opportunities by using the final specifier (C++11)

* Declaring CCoinsViewErrorCatcher final enables devirtualization of two calls
* Declaring CReserveKey final enables devirtualization of one call

db53d980af

practicalswift force-pushed on Jul 16, 2017
practicalswift commented at 9:45 PM on July 16, 2017: contributor

@sipa Thanks for letting me know about @theuni:s PR #10809! I've now removed the changes to the overlapping classes from this PR. @theuni, let me know if you want to incorporate the changes to the remaining two classes in your PR #10809 instead. If so, I'll close this one :-)
TheBlueMatt commented at 10:35 PM on July 16, 2017: member

utACK db53d980af65adeff1d8816ebbb4997ab780e6dd
fanquake added the label Refactoring on Jul 17, 2017
laanwj commented at 6:07 AM on July 17, 2017: member

Can we try to do this in one go with #10809? Seems nonsense to have multiple PRs open for this.
practicalswift commented at 7:55 AM on July 17, 2017: contributor

@laanwj Makes sense - closing! :-)
practicalswift closed this on Jul 17, 2017
practicalswift deleted the branch on Apr 10, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels