Avoid redundant redeclaration of GetWarnings(const string&) #10864

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:GetWarnings-in-warnings.h changing 6 files +11 −9

practicalswift commented at 1:13 PM on July 18, 2017: contributor

Avoid redundant redeclaration of GetWarnings(const string&).

std::string GetWarnings(const std::string& strFor) is declared in warnings.h and defined in warnings.cpp.

Avoid redundant redeclaration of GetWarnings(const string&)

std::string GetWarnings(const std::string& strFor) is declared in
warnings.h and defined in warnings.cpp.

e0d459264f

in src/validation.h:277 in 3a46c35011 outdated

 274 | @@ -275,7 +275,6 @@ bool IsInitialBlockDownload();
 275 |   * - "gui": get all warnings, translated (where possible) for GUI
 276 |   * This function only returns the highest priority warning of the set selected by strFor.
 277 |   */

MarcoFalke commented at 1:35 PM on July 18, 2017:

What about the documentation?

practicalswift commented at 1:55 PM on July 18, 2017:

Fixed! Thanks!

practicalswift force-pushed on Jul 18, 2017
TheBlueMatt commented at 8:49 PM on July 18, 2017: member

utACK e0d459264fa9330eea99d33208fbddb8c8362be4
MarcoFalke commented at 9:39 PM on July 18, 2017: member

utACK e0d4592
sipa commented at 3:57 AM on July 19, 2017: member

utACK e0d459264fa9330eea99d33208fbddb8c8362be4
jonasschnelli added the label Refactoring on Jul 19, 2017
jonasschnelli commented at 9:51 AM on July 19, 2017: contributor

utACK e0d459264fa9330eea99d33208fbddb8c8362be4
jonasschnelli merged this on Jul 19, 2017
jonasschnelli closed this on Jul 19, 2017
jonasschnelli referenced this in commit a6ec5802b0 on Jul 19, 2017
jonasschnelli commented at 10:12 AM on July 19, 2017: contributor

Sorry. I accidentally merged this after the freeze.
PastaPastaPasta referenced this in commit 2b8201f90a on Jul 17, 2019
PastaPastaPasta referenced this in commit 1b4c5043ec on Jul 17, 2019
PastaPastaPasta referenced this in commit 6a6c903283 on Jul 23, 2019
PastaPastaPasta referenced this in commit 2ada45284b on Jul 24, 2019
barrystyle referenced this in commit bd56a53266 on Jan 22, 2020
practicalswift deleted the branch on Apr 10, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels